1777495 - PDF and WORD attachments are blank after sending to Proton Mail

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Dave]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

Send Email to protonmail.com address with a PDF or Word attachment after upgrading from TB 91 to 102.
No extra filters are active at Protonmail and sending from the protonmail web app is working correctly.
Tried reinstalling the protonmail account in thunderbird and reinstalling the protonmail bridge app.

Actual results:

Mail is sent correctly and attachments are still attached but when opened are blank.
For PDF's, pages are still shown and page count is correct but no content.
For Word file is empty and Word flags as corrupt.
The copy remaining in the protonmail sent folder is also affected in the same way and the receiver's email.

Expected results:

Attachments remain unchanged

Comment 1

[R]

Are you sure the attached word files are empty? In my case (docs, xlsx-attachments) were "corrupted" and slightly bigger. Opening them in Notpad++ tells me they are encoded in ANSI (was UTF8 before). And I got \ufffd () as a character inserted in some places. Seems to be a replacement char for utf, see https://www.fileformat.info/info/unicode/char/fffd/index.htm

Comment 2

[R]

And to confirm: Problem existing only using protonmail bridge. I contacted proton support. Perhaps you should too.

Comment 3

[Dave]

I contacted Protonmail a few days ago and they have replied that is a known issue and are working it.
But, the issue only exist with the change to Thunderbird 102 , so it may still be an issue that needs to be worked from the Thunderbird side as well.

Comment 4

[andrzej.sz]

hi, Proton here. we've looked into this at our end and confirmed that the problem comes from the new TB 102 adding charset=windows-1250 to all attachments, not just to text.
Based on this Bridge converts all these to utf8 which changes the data of binary files.
We can fix it at our end and maybe could handle it better from the beginning, but are puzzled as of why TB changed this in the first place just now.
As per https://datatracker.ietf.org/doc/html/rfc2046#section-4.1.2 this is not strictly forbidden, but would be great to know it it is deliberate and what is the reasoning behind it.
And/or if TB is planning a hotfix for this.

Comment 5

[Ping Chen [:rnons] (away)]

confirmed that the problem comes from the new TB 102 adding charset=windows-1250 to all attachments, not just to text.

Looks like a regression from bug 1760728, I will make a fix soon. Thanks.

Comment 6

[Ping Chen [:rnons] (away)]

Attachment: Bug 1777495 - Do not add charset param to non-text attachments. r=#thunderbird-reviewers

A mistake made in D141715.

Comment 7

[andrzej.sz]

good to know, thanks for speedy answer. any ETA on the hotfix? we have some quite a few users unable to send attachments, so looks pretty serious :/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0a6dd8df110f
Do not add charset param to non-text attachments. r=#thunderbird-reviewers,freaktechnik

Comment 9

[Ping Chen [:rnons] (away)]

Comment on attachment 9284417 [details]
Bug 1777495 - Do not add charset param to non-text attachments. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1760728
User impact if declined: Attachments become blank when sent to Proton
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 10

[Alessandro Castellani [:aleca]]

I suspect this patch caused this failure: https://treeherder.mozilla.org/logviewer?job_id=383706808&repo=comm-central&lineNumber=2528

Comment 11

[Ping Chen [:rnons] (away)]

In this case, D141905 should be backed out. Or I can send a patch to revert D141905, which do you prefer?

Comment 12

[Ping Chen [:rnons] (away)]

Attachment: 1777495-follow.patch

Revert bug 1761101.

Comment 13

[Alessandro Castellani [:aleca]]

Yeah, a patch is better since backing out something from 4 months ago doesn't make much sense.
If the code changes, the tests should follow.
Can you please add this to Phab, and kick a try-run just to be sure? So then I can push a DONTBUILD with it

Comment 14

[Ping Chen [:rnons] (away)]

Attachment: Bug 1777495 follow-up - Revert bug 1761101 to fix browser_inlineImage.js. r=aleca,#thunderbird-reviewers

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bf960b3941c6
Follow-up: Revert bug 1761101 to fix browser_inlineImage.js. r=#thunderbird-reviewers,rjl

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9284417 [details]
Bug 1777495 - Do not add charset param to non-text attachments. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Unless a new patch is needed?

Comment 17

[Rob Lemley [:rjl]]

Thunderbird 103.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/52f7ad48d71d
https://hg.mozilla.org/releases/comm-beta/rev/8f6d19699332

Comment 21

[Ping Chen [:rnons] (away)]

Comment on attachment 9284417 [details]
Bug 1777495 - Do not add charset param to non-text attachments. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1760728
User impact if declined: Attachments become blank when sent to Proton
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low

Comment 22

[Rusty]

Not sure what to do. This just started a week or two ago. Why doesn't Thunderbird fix what they did in that update that caused this problem, and put out another update?

Comment 23

[Magnus Melin [:mkmelin]]

There is an update coming (that's what the approval requests are about). We have to test it on beta first to make sure everything is alright.

Comment 25

[Wayne Mery (:wsmwk)]

Comment on attachment 9284417 [details]
Bug 1777495 - Do not add charset param to non-text attachments. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102 with follow up patch if needed.

Comment 26

[Rusty]

Hi. This says bug FIXED. Is that because there's a fix or update that has not yet been released, or am I missing something I'm supposed to do? Thanks.

Comment 27

[ErikA]

It says fixed for version 103, which is currently being tested. You need to wait for its release.

Comment 28

[Rusty]

THANKS!

Comment 29

[Rob Lemley [:rjl]]

Thunderbird 102.0.3:
https://hg.mozilla.org/releases/comm-esr102/rev/9252ddbc900b
https://hg.mozilla.org/releases/comm-esr102/rev/885507444351

Comment 30

[Dave]

Working Here for both attachment types.
Thank you.

Comment 31

[Dave]

(In reply to Dave from comment #30)
102.0.3 (64-bit

Comment 32

[Thomas D. (:thomas8)]

Verified per Dave's comment 30, comment 31.