1777505 - Intermittent comm/mail/components/addrbook/test/browser/browser_display_card.js | Cards list should have focus (actual: cards) - false == true

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nicolai [at] thunderbird.net
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=383001559&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/aGXVWI3ATx-ujGARxkXvbw/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[u695164]

The log seems actually solid.
Cards list should have focus (actual: cards)
Could reproduce this locally with ./mach test --verify. (linux)
An ordinary ./mach test seems fine.

Comment 2

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Nicolai Kasper from comment #1)

The log seems actually solid.
Cards list should have focus (actual: cards)
Could reproduce this locally with ./mach test --verify. (linux)
An ordinary ./mach test seems fine.

Yeah, I didn't notice it locally either.

I actually test for .matches(":focus") rather than just comparing against document.activeElement (which is what the (actual: cards) message uses). The difference is that an element will only have :focus if the window also has focus. Looking at the screenshot it seems that there is still a dialog open, which has focus: https://firefoxci.taskcluster-artifacts.net/aGXVWI3ATx-ujGARxkXvbw/0/public/test_info/mozilla-test-fail-screenshot_wm0247ew.png

Maybe we're not waiting long enough for it to close.

Comment 3

[Henry Wilkes (they/them) [:henry-x]]

Geoff, do you know what might be happening?

According to this line https://treeherder.mozilla.org/logviewer?job_id=383001559&repo=comm-central&lineNumber=5257 the dialog is closed. And this is after a await BrowserTestUtils.domWindowClosed https://searchfox.org/comm-central/rev/bbad2db99551a14a1a6062a7c6d6b1d9c094cbf7/mail/components/addrbook/test/browser/browser_display_card.js#590-594

But the screen shot taken here https://firefoxci.taskcluster-artifacts.net/aGXVWI3ATx-ujGARxkXvbw/0/public/test_info/mozilla-test-fail-screenshot_wm0247ew.png, which I assume is taken when the :focus is tested for, it is shows as still open.

Is there something else we should wait for for the focus to return to the main window? Or should I just change the test from

Assert.ok(cardsList.matches(":focus"));

to

Assert.equal(cardsList, abDocument.activeElement);

Comment 4

[Geoff Lankow (:darktrojan)]

You could try waiting for Services.focus.activeWindow to be equal to window. That might help.

Comment 5

[Intermittent Failures Robot]

2 failures in 3312 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• linux1804-64-qr: 1
  • opt: 1
• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1777505&startday=2022-06-27&endday=2022-07-03&tree=all

Comment 6

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Geoff Lankow (:darktrojan) from comment #4)

You could try waiting for Services.focus.activeWindow to be equal to window. That might help.

Thank you. That is what I was looking for. Unfortunately I tried waiting for this, and I tried with abDocument.hasFocus(), but it was not enough.

I give up. I'll just test against activeElement.

Comment 7

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1777505 - Test against activeElement rather than ":focus" in browser_display_card. r=#thunderbird-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fc116ed0ac04
Test against activeElement rather than ":focus" in browser_display_card. r=#thunderbird-reviewers,freaktechnik

Comment 9

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9284146 [details]
Bug 1777505 - Test against activeElement rather than ":focus" in browser_display_card. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1752013
User impact if declined: Needed on beta since the patch for bug 1752013 landed there https://bugzilla.mozilla.org/show_bug.cgi?id=1752013#c30 and will cause intermittent failures.
Testing completed (on c-c, etc.): No new intermittent failures on comm-central since landing.
Risk to taking this patch (and alternatives if risky): Low

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9284146 [details]
Bug 1777505 - Test against activeElement rather than ":focus" in browser_display_card. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 103.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/335a7b0c53ee

Comment 12

[Rob Lemley [:rjl]]

Comment on attachment 9284146 [details]
Bug 1777505 - Test against activeElement rather than ":focus" in browser_display_card. r=#thunderbird-reviewers

[Triage Comment]
Test-only fix for regressing bug 1752013, uplifted to c-esr102.

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 102.0.2:
https://hg.mozilla.org/releases/comm-esr102/rev/0a00f225115f

Comment 14

[Intermittent Failures Robot]

4 failures in 3072 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 4

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1
• linux1804-64-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1777505&startday=2022-07-04&endday=2022-07-10&tree=all