1777520 - Import tool gets stuck in step 2 after flashing red message "No Profile found" (Seamonkey, Outlook)

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P4)

Description

[Thomas D. (:thomas8)]

Maybe a runtime thing, or maybe only reproduces first time?
A bit erratic, but have seen it twice now

STR (new, better STR in comment 3)

1. Tools > Import
2. Choose Seamonkey or Outlook as source in step 1 of import
3. After getting red error "No Profile found" in step 2 of import, try Back button

Actual result

• in step 2 of import, red message flashes "No Profile found"
• back button thereafter fails to go back to step 1

Expected

• back button should always work correctly

Workaround is to call import tool from menu again.

Comment 1

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Stuck in step 2, and the UI looks bogus?

Stuck in step 2, and the UI looks bogus?

Comment 2

[Martin Giger [:freaktechnik]]

I can't reproduce this, though I haven't yet had a chance to try on Windows. The error should only be shown if you click next after you made a selection in the second step.

Could you check the error console to see if there's anything there?

Your screenshot looks like a case where the import tab didn't get initialized correctly, and is thus showing things it shouldn't be showing. You can also see that it thinks it's on the initial step.

Comment 3

[Thomas D. (:thomas8)]

New STR

1. Tools > Import
2. Choose Seamonkey, Continue
3. < Back
4. Choose Outlook, Continue ("No Profile found")
5. < Back

Actual

• Outlook step 2 shows step 2 of SeaMonkey instead (under "No Profile found" bar)
• < Back fails, just removes the "No Profiles found" bar

Uncaught TypeError: tab.browser.contentWindow.showTab is not a function
    toImport chrome://messenger/content/mailCore.js:549
    setTimeout handler*toImport chrome://messenger/content/mailCore.js:548
    oncommand chrome://messenger/content/messenger.xhtml:1
mailCore.js:549:39


Uncaught (in promise) Error: No profile found, do not advance to app flow.
    _onSelectSource chrome://messenger/content/aboutImport.js:382
aboutImport.js:382:13

Uncaught TypeError: targetStep is undefined
    backTo chrome://messenger/content/aboutImport.js:117
    back chrome://messenger/content/aboutImport.js:172
    onclick about:import#:1
aboutImport.js:117:5
    backTo chrome://messenger/content/aboutImport.js:117
    back chrome://messenger/content/aboutImport.js:172
    onclick about:import#:1
​```

Comment 4

[Martin Giger [:freaktechnik]]

Attachment: Bug 1777520 - Properly handle no profiles found in import. r=#thunderbird-reviewers

Comment 5

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/comm-central/rev/80e55dc39cab

Comment 6

[Martin Giger [:freaktechnik]]

Comment on attachment 9283812 [details]
Bug 1777520 - Properly handle no profiles found in import. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Import flow breaks after selecting an app that has no profiles and no folder/zip selection option
Testing completed (on c-c, etc.): Tested on c-c
Risk to taking this patch (and alternatives if risky): Low risk, tiny fix of missed error handling.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9283812 [details]
Bug 1777520 - Properly handle no profiles found in import. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 103.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/16fb5d4b49c4

Comment 9

[Rob Lemley [:rjl]]

Comment on attachment 9283812 [details]
Bug 1777520 - Properly handle no profiles found in import. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Import flow breaks after selecting an app that has no profiles and no folder/zip selection option
Testing completed (on c-c, etc.): 103.0b3
Risk to taking this patch (and alternatives if risky): Low risk, tiny fix of missed error handling.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9283812 [details]
Bug 1777520 - Properly handle no profiles found in import. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 102.0.2:
https://hg.mozilla.org/releases/comm-esr102/rev/f8078efc9b63