1777642 - Should use GetMessageHeader instead of getMessageHeader in NntpChannel.jsm

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect, P2)

Description

[Ping Chen [:rnons] (away)]

https://searchfox.org/comm-central/rev/dd599f9eb4366cbe81365c5d3f1e63b3445277dc/mailnews/base/public/nsIMsgFolder.idl#576

Will fix ImapChannel.jsm in bug 1762688.

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1777642 - Use GetMessageHeader instead of getMessageHeader in NntpChannel.jsm. r=#thunderbird-reviewers

Comment 2

[Wayne Mery (:wsmwk)]

What broke for the user as a result of this?

Comment 3

[Ping Chen [:rnons] (away)]

Offline cache can't be used by nntp, even if user has already downloaded all the messages. This problem is unnoticeable if not in offline mode, because the code will fallback to fetch from server.

Comment 4

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/comm-central/rev/47417ab9d7f7

Comment 5

[Ping Chen [:rnons] (away)]

Comment on attachment 9283781 [details]
Bug 1777642 - Use GetMessageHeader instead of getMessageHeader in NntpChannel.jsm. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1733849
User impact if declined: Offline storage can't be used by NNTP.
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): no risk, basically a typo fix.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9283781 [details]
Bug 1777642 - Use GetMessageHeader instead of getMessageHeader in NntpChannel.jsm. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 103.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/fa6ba9b18e04

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9283781 [details]
Bug 1777642 - Use GetMessageHeader instead of getMessageHeader in NntpChannel.jsm. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1733849
User impact if declined: Offline storage can't be used by NNTP.
Testing completed (on c-c, etc.): 103.0b4
Risk to taking this patch (and alternatives if risky): no risk, basically a typo fix.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9283781 [details]
Bug 1777642 - Use GetMessageHeader instead of getMessageHeader in NntpChannel.jsm. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 102.0.2:
https://hg.mozilla.org/releases/comm-esr102/rev/c253ab4c18ff

Comment 11

[Rob Lemley [:rjl]]

Backout Thunderbird 102.0.2:
https://hg.mozilla.org/releases/comm-esr102/rev/1357fff4c27503ee29b594ab715648f48af3bd45

Backed out for causing ESLint test failure:
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/news/src/NntpChannel.jsm:29:13 | 'lazy' is not defined. (no-undef)

Comment 12

[Ping Chen [:rnons] (away)]

Attachment: 1777642-esr102.patch

One line change for esr102, thanks.

Comment 13

[Wayne Mery (:wsmwk)]

Thanks for the updated patch. Given the modest severity, even though it's regression, I'm going to proceed building 102.0.2 without this patch. Let me know if you disagree with targeting this to the next esr.

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9284776 [details] [diff] [review]
1777642-esr102.patch

[Triage Comment]
Approved for esr102

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 102.0.3:
https://hg.mozilla.org/releases/comm-esr102/rev/fe64edafc085