1777890 - The multi-process chunk manager update logic is never started, removing the overall buffer size limit

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Spawned from bug 1777431 comment 2:
The logic that keeps the total profile buffer memory in check is not even started! So chunk updates from child processes were ignored, and these processes are allowed to grow to their local limit, which could explain recent "big profile" issues like bug 1758643.

This was regressed in bug 1668867, patch D139333, which mistakenly removed ProfilerParentTracker::ProfilerStarted(ipcParams.entries());.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1668867

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1777890 - Re-enable the chunk manager logic to limit the global profile buffer memory usage - r?canaltinova

Fix for a regression in bug 1668867, which removed this important line.
Without it, the logic that handles chunk manager updates doesn't run, and the
overall buffer size limit across processes is not enforced anymore.

To catch future regressions, the ProfileBufferGlobalController now adds its
creation timestamp to the profiling log, which can be tested.

Depends on D150562

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c06c7a054281
Re-enable the chunk manager logic to limit the global profile buffer memory usage - r=canaltinova

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c06c7a054281