Crash in [@ mozilla::SharedStyleSheetCache::LoadCompletedInternal]
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox-esr102 | --- | unaffected |
firefox102 | --- | unaffected |
firefox103 | --- | unaffected |
firefox104 | --- | wontfix |
firefox105 | --- | wontfix |
firefox106 | --- | wontfix |
People
(Reporter: aryx, Assigned: emilio, NeedInfo)
References
Details
(Keywords: crash, topcrash)
Crash Data
Attachments
(1 file)
20 crashes from 12 installations, all with Firefox 104.0a1 starting with 20220629070023. Chinese and Spanish are overrepresented in the crash reports. The crashes are reported for documents loaded in extension processes.
Changelog which likely added the regression
Emilio, could you investigate?
Crash report: https://crash-stats.mozilla.org/report/index/d9a18962-3cc1-4698-a5b4-675280220704
MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(value)
Top 10 frames of crashing thread:
0 xul.dll static mozilla::SharedStyleSheetCache::LoadCompletedInternal layout/style/SharedStyleSheetCache.cpp:113
1 xul.dll static mozilla::SharedStyleSheetCache::LoadCompleted layout/style/SharedStyleSheetCache.cpp:63
2 xul.dll mozilla::css::SheetLoadData::VerifySheetReadyToParse layout/style/Loader.cpp:704
3 xul.dll mozilla::css::StreamLoader::OnStopRequest layout/style/StreamLoader.cpp:81
4 xul.dll std::_Func_impl_no_alloc<`lambda at /builds/worker/checkouts/gecko/netwerk/protocol/http/HttpChannelChild.cpp:786:13', void>::_Do_call
5 xul.dll mozilla::net::ChannelEventQueue::FlushQueue netwerk/ipc/ChannelEventQueue.cpp:94
6 xul.dll mozilla::net::ChannelEventQueue::ResumeInternal::CompleteResumeRunnable::Run netwerk/ipc/ChannelEventQueue.cpp:152
7 xul.dll mozilla::SchedulerGroup::Runnable::Run xpcom/threads/SchedulerGroup.cpp:140
8 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:851
9 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1205
Assignee | ||
Comment 1•2 years ago
|
||
I don't see anything particularly likely to cause this in that pushlog unfortunately.
Most of the URLs in the crash report are from extensions like: moz-extension://eb04ea5d-630b-412d-9cfb-269c9995c0e9/src/action/index.html
Andreas, do you know how could I find which extension popup does that correspond to?
Comment 2•2 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)
I don't see anything particularly likely to cause this in that pushlog unfortunately.
Most of the URLs in the crash report are from extensions like: moz-extension://eb04ea5d-630b-412d-9cfb-269c9995c0e9/src/action/index.html
Andreas, do you know how could I find which extension popup does that correspond to?
The moz-extension UUID is generated per install, so it's impossible to say without more information, unfortunately.
Comment 3•2 years ago
|
||
Notably, this is a diagnostic assert (so it's nightly/early-beta only). So Firefox release users will sail right past this without crashing, probably without too much going wrong in this case.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
The only thing that could trigger this is a bogus key, or overriding an
already-loading stylesheet which we didn't correctly coalesce.
Either of those is a bug.
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42150cbcb4fc Add a few diagnostic asserts to the sub-resource cache. r=dholbert,layout-reviewers
Comment 6•2 years ago
|
||
bugherder |
Comment 7•2 years ago
|
||
The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox104
towontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 8•2 years ago
|
||
I guess this doesn't fix the crash (only possibly moves it)
Updated•2 years ago
|
Reporter | ||
Updated•2 years ago
|
Comment 9•2 years ago
•
|
||
emilio, any other ideas here? Any additional diagnostic asserts that we could add to test other theories?
Assignee | ||
Comment 10•2 years ago
|
||
Not really, given crash volume doesn't feel like S3 tho.
Updated•1 year ago
|
Comment 11•21 days ago
|
||
The bug is linked to a topcrash signature, which matches the following criterion:
- Top 10 AArch64 and ARM crashes on beta
:emilio, could you consider increasing the severity of this top-crash bug?
For more information, please visit BugBot documentation.
Assignee | ||
Comment 12•21 days ago
|
||
Sunil, might this spike be due to bug 1864817? There are no crashes on release or past beta6, so it sure smells like it...
Updated•7 days ago
|
Comment 13•7 days ago
|
||
May be I am missing something Emilio?
Looking at this graph for the nightly release I don't see any new spikes after merging my ODF patch on March 10th?
Description
•