1864817 - Process OnDataFinished for CSSLoader

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P2)

Description

[Sunil Mayya]

With 1851992, we have supported interfaces to send OnDataFinished to stream listeners. Currently the only listener that support processing of OnDataFinished is Html5Parser.

In this bug, we will support processing of OnDataFinished in CSSLoader

Comment 1

[Sunil Mayya]

Attachment: Bug 1864817 - implement OnDataFinished for CSSLoader. r=#necko,jesup,emilio

Comment 2

[Sunil Mayya]

Attachment: Bug 1864817 - dispatch SheetFinishedParsingAsync only after main thread OnStopRequest. r=emilio

Depends on D189403

Comment 3

[Sunil Mayya]

Attachment: Bug 1864817 - postpone moving StreamLoader::mBytes after VerifySheetReadyToParse in StreamLoader::OnStopRequest. r=emilio

Depends on D198138

Comment 4

[Sunil Mayya]

Attachment: Bug 1879207 - initialize STYLE_THREAD_POOL in Sevo_initialize. r=emilio,jesup

Comment 5

[Sunil Mayya]

Attachment: Bug 1864817 - ensure thread pool initialization in main thread.r=emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14d68154a5be
initialize STYLE_THREAD_POOL in Sevo_initialize. r=emilio,jesup

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/14d68154a5be

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9da36d4b3b14
implement OnDataFinished for CSSLoader. r=jesup,necko-reviewers,emilio

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out for causing frequent StyleSheet related failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Ctsan%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-linux1804-64-tsan-qr%2Fopt-web-platform-tests-reftest%2Cwr2&revision=9da36d4b3b141ec6a98955bc2b384e832a1b079b&selectedTaskRun=D0lvZ_MSTturH4zhtGSwfA.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=450144872&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=450140858&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/bb7f58e9746c8c734707536fdf71a59108fe4fd3

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/9a7259a1e332
Backed out changeset 9da36d4b3b14 for causing frequent StyleSheet related failures. CLOSED TREE

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efd0e2ab4a14
implement OnDataFinished for CSSLoader. r=jesup,necko-reviewers,emilio

Comment 12

[Emilio Cobos Álvarez (:emilio)]

I don't think we should need the StyleSheet mutex...

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/efd0e2ab4a14