1778221 - After TB102 update -- AppMenu display cut off

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[duc]

Attachment: Thunderbird102HamburgerMenu.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

Customize Menu Bar to place app menu icon (aka hamburger icon) to the far left. Click to open up app menu to see pop up is cut off to its left, whether in full screen mode or resized mode.

Actual results:

Thunderbird 102 must not recognize my display size and/or the scaling that is set on my Win10 install, currently set to 125%. Using native display resolution, which is FHD (1920 x 1080).

Expected results:

It should not be cut-off.

Comment 1

[duc]

Attachment: Resized window with drop-down app menu still cut-off

Comment 2

[Wayne Mery (:wsmwk)]

I recall seeing a recent (bug?) report about File menu being offset by the spaces toolbar - I can't find it right now.
Will that bug also fix this

Comment 3

[Alessandro Castellani [:aleca]]

The spaces toolbar shouldn't affect this.
The app menu cutting outside the visible screen seems to me like an m-c styling issue of the popup panel element.
Can you reproduce this in Firefox as well?

Gently pinging Richard to see if he can reproduce the issue.

Comment 4

[Richard Marti (:Paenglab)]

FX would have the same issue when the AppButton would be movable.

The problem is, that the popup opens with position="bottomcenter topright". If we could change this to position="bottomcenter topleft" when the button is placed on the left side of the toolbar. Then it would also stay inside of the TB window.

As a quick fix we could do:

#appMenu-popup {
  margin-inline-start: 0;
}

then the popup can't go off-screen on the left

Comment 5

[Alessandro Castellani [:aleca]]

The problem is, that the popup opens with position="bottomcenter topright". If we could change this to position="bottomcenter topleft" when the button is placed on the left side of the toolbar. Then it would also stay inside of the TB window.

I don't think we can detect that easily unfortunately.
We will rebuild our toolbar for 114 so this problem won't happen, but I think your temporary solution of the inline margin is a good fix for now.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Bug 1778221 - Don't let the appMenu-popup draw off-screen. r=aleca

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2115178fdabd
Don't let the appMenu-popup draw off-screen. r=aleca

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9284373 [details]
Bug 1778221 - Don't let the appMenu-popup draw off-screen. r=aleca

[Approval Request Comment]
User impact if declined: the AppMenu can be partly off-screen
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9284373 [details]
Bug 1778221 - Don't let the appMenu-popup draw off-screen. r=aleca

[Triage Comment]
Approved for beta

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 103.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/2458c361d875

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9284373 [details]
Bug 1778221 - Don't let the appMenu-popup draw off-screen. r=aleca

[Triage Comment]
Approved for esr102

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 102.0.2:
https://hg.mozilla.org/releases/comm-esr102/rev/79b59c2e4e8c