1779231 - Add Realm support to "target" argument for "script.evaluate", "script.callFunction", and "script.disown"

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Once we have sandbox support for script.evaluate (bug 1770480) and can retrieve existing realms (bug 1766240) we can finally add Realm support for the target argument.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Given the small differences to script.callFunction lets cover both on the same bug.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

We should wait until the script.disown command has been implemented as well.

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1779231 - [bidi] Add Realm support to "target" argument for "script.evaluate", "script.callFunction" and "script.disown"

Depends on D156051

Comment 4

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1779231 - [wdspec] Add tests for realm in target argument for "script.evaluate", "script.callFunction" and "script.disown".

Depends on D156690

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1779231 - [wdspec] Move argument and this argument callFunction tests to separate files.

Depends on D156690

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4379621516e9
[bidi] Add Realm support to "target" argument for "script.evaluate", "script.callFunction" and "script.disown" r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/db18156a5524
[wdspec] Move argument and this argument callFunction tests to separate files. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/f1387a8dfb7f
[wdspec] Add tests for realm in target argument for "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo,jdescottes

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35962 for changes under testing/web-platform/tests

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4379621516e9
https://hg.mozilla.org/mozilla-central/rev/db18156a5524
https://hg.mozilla.org/mozilla-central/rev/f1387a8dfb7f

Comment 9

[Alexandra Borovova [:Sasha]]

Comment on attachment 9293492 [details]
Bug 1779231 - [bidi] Add Realm support to "target" argument for "script.evaluate", "script.callFunction" and "script.disown"

Beta/Release Uplift Approval Request

• User impact if declined: A user will not be able to start using "script.evaluate", "script.callFunction" and "script.disown" commands.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1778976
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It introduces only a new functionality to the BiDi commands, all the changes are tests with wdspec tests.
• String changes made/needed:
• Is Android affected?: Yes

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9293492 [details]
Bug 1779231 - [bidi] Add Realm support to "target" argument for "script.evaluate", "script.callFunction" and "script.disown"

Approved for 106.0b3, thanks.

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/f365465f6d6d
https://hg.mozilla.org/releases/mozilla-beta/rev/25bc83e275ed
https://hg.mozilla.org/releases/mozilla-beta/rev/3f01c4c4e597

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham