1778976 - Enable "script.evaluate", "script.callFunction" and "script.disown" on release channels

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Alexandra Borovova [:Sasha]]

After https://bugzilla.mozilla.org/show_bug.cgi?id=1777951 land, "script.evaluate" and "script.callFunction" will be pref'ed off on release channels.

As soon as these commands are fully implemented, we can enable them on release channels.

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1778976 - [bidi] Enable "script.evaluate", "script.callFunction" and "script.disown" on release channels.

Depends on D156691

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9416866a030b
[bidi] Enable "script.evaluate", "script.callFunction" and "script.disown" on release channels. r=webdriver-reviewers,whimboo

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9416866a030b

Comment 4

[Alexandra Borovova [:Sasha]]

Comment on attachment 9294205 [details]
Bug 1778976 - [bidi] Enable "script.evaluate", "script.callFunction" and "script.disown" on release channels.

Beta/Release Uplift Approval Request

• User impact if declined: A user will not be able to start using "script.evaluate", "script.callFunction" and "script.disown" commands.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1779231
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This bug only removes check for pref and make the command available by default. These commands are heavily tested with wdspec tests.
• String changes made/needed:
• Is Android affected?: Yes

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9294205 [details]
Bug 1778976 - [bidi] Enable "script.evaluate", "script.callFunction" and "script.disown" on release channels.

Approved for 106.0b3, thanks.

Comment 6

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/f1e0c1cdc215

Comment 7

[Julian Descottes [:jdescottes]]

Adding webdriver:relnote

Added support for three commands of the script module. The "evaluate" command allows to evaluate a JavaScript expression and retrieve the result as a serialized remote value. "callFunction" is similar, but allows to execute a function declaration, which supports "arguments" and "this" parameters. "arguments" and "this" can be any remote value, including remote references directly mapped to objects retrieved from previous calls to "evaluate" or "callFunction". Those remote references require strong references to be created to avoid garbage collection issues, but they can be deleted explicitly using the "disown" command.

See comment #9 .

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Julian. This description is quite long. I think we should condense the contents for the release notes PR to some very basic information. Given that we deliver the bug numbers as well interested users can get detailed information on the bug.

Comment 9

[Julian Descottes [:jdescottes]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #8)

Thanks Julian. This description is quite long. I think we should condense the contents for the release notes PR to some very basic information. Given that we deliver the bug numbers as well interested users can get detailed information on the bug.

Added full support for the "evaluate", "callFunction" and "disown" commands of the script module.