Address Book: "Get Map" button is not shown for home addresses
Categories
(SeaMonkey :: MailNews: Address Book & Contacts, defect)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: nunojsg, Assigned: nunojsg)
References
Details
(Whiteboard: SM2.53.14)
Attachments
(1 file)
2.15 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
When displaying contacts/cards, the Address Book can show "Get Map" buttons for street addresses which are set, but currently (I've been testing with 2.53.12 and a 2.53.13b1pre build) it will only show this button for the work address.
This appears to be caused by the changes in bug 1428100. For both Home/Private and Work contact sections, there is a variable that signals whether there is content to display so far. In both SeaMonkey and Thunderbird, this variable is named "visible" for the Home/Private section and "addressVisible" for the Work section, but the suite/ part of the patch uses "addressVisible" for both sections.
Assignee | ||
Updated•9 months ago
|
Assignee | ||
Comment 1•9 months ago
|
||
![]() |
||
Updated•9 months ago
|
![]() |
||
Comment 2•9 months ago
|
||
Comment on attachment 9285251 [details] [diff] [review]
1779319-get-map-addressVisible
Stealing review. LGTM
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/c19375099a8b
Address Book: Unhide "Get Map" button for Home addresses. r=frg
![]() |
||
Updated•8 months ago
|
![]() |
||
Comment 4•5 months ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/12867f9ed45dae0a6b8e34e9d44669d6a796b3f5
Address Book: Unhide "Get Map" button for Home addresses. r=frg a=frg
Description
•