1779367 - MOZ_CRASH(IPC message size is too large) when capturing a profile

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Found in this Try: https://treeherder.mozilla.org/jobs?repo=try&revision=c6389bc85015b9d8f90c9adb481860681bde4cd7&selectedTaskRun=R4kJqij0SCS53bV-ZStZOw.0

This was when a child process sent its profile to the parent.
IPC messages are limited to 256MiB: https://searchfox.org/mozilla-central/rev/0d7e190891e62276cf934cc0b96b22e8e086ddb9/ipc/chromium/src/chrome/common/ipc_channel.h#85

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1779367 - Don't send shutdown profiles that don't fit in an IPC message - r?florian

Instead of trying to send a too-big message, send a short message starting
with '*', which the parent can put into the profileGatheringLog.

Depends on D152026

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1779367 - If a shmem cannot be created for a child profile, send a message instead - r?florian

Instead of trying to create a too-big shmem, or if the shmem creation fails,
send a short message starting with '*', which the parent can put into the
profileGatheringLog.

Depends on D152027

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a58be620f788
Don't send shutdown profiles that don't fit in an IPC message - r=florian
https://hg.mozilla.org/integration/autoland/rev/70cacc19a882
If a shmem cannot be created for a child profile, send a message instead - r=florian

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a58be620f788
https://hg.mozilla.org/mozilla-central/rev/70cacc19a882

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Copying crash signatures from duplicate bugs.