Open Bug 1780330 Opened 3 years ago Updated 2 years ago

Change PContent's ShutdownProfile IPC to pass a shmem and pid

Categories

(Core :: Gecko Profiler, task, P3)

Product:
Core
Component:
Gecko Profiler
Type:
task

Tracking

()

People

(Reporter: mozbugz, Unassigned)

References

Details

The current ShutdownProfile IPC passes the shutdown profile by string.
Because of the IPC message limit of 256MB, some big child-process profiles could be discarded.
For comparison, PProfiler's GatherProfile uses a shmem, which allows bigger profiles -- still effectively limited to 1GB, to fit in a JS string.

So to remove this IPC limitation, ShutdownProfile should be modified to pass a shmem.
And while modifying it, we should also pass the source pid (process id), which will be useful to identify that sub-profile if needed.

Note: Bug 1779367 changed ProfilerChild::GrabShutdownProfile to catch profiles that would be over the IPC message limit, it should also be changed to the higher JS string limit.

You need to log in before you can comment on or make changes to this bug.