1779589 - [Colorway Closet] Color bubbles on Innovator section are moving their position due to a two-line description

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Mehmet]

Attachment: Screencast of the issue

Nightly 104.0a1 (2022-07-14) (64-Bit)
macOS

1.) Activate Colorway Closet
2.) Navigate through all 6 sections by clicking on the color bubbles

Actual: Color bubbles on Innovator section are moving their position due to a two-line description

Expected: A fixed position for the color selection bubbles.

Maybe this is possible to fix :)

Thanks you.

Comment 1

[Mehmet]

I wondered why I wasn't able to reproduce this on another device until I noticed that this depends on the window size and a word-wrapping in the long sentences is happening :)

Comment 2

[Mehmet]

Attachment: Screencast of the issue in narrow window.mov

FYI: This seems to be fixed now when the selector and text section is on the right side of the modal (and the logo is to the left). But this is still reproducible when you shrink the window to a very narrow size so that the selector and text section appear below the logo. Then the selector bubbles still change their position when switching between them. A screencast is attached.

Tested in Nightly 104.0a1 (2022-07-21) (64-Bit)

Comment 3

[Dão Gottwald [:dao]]

So I think bug 1782168 improved this quite a bit, to the point where it should be fine in most cases. I think there are still some edge cases left where the size can change, but so far I haven't found a way to fix that without making the layout worse in more common scenarios, so I wonder if we should just leave this as-is.

Amy, did you have a specific plan here? Would you like to give this another try or do you agree we can leave this as-is?

Comment 4

[Amy Churchwell [:amy]]

(In reply to Dão Gottwald [::dao] from comment #3)

So I think bug 1782168 improved this quite a bit, to the point where it should be fine in most cases. I think there are still some edge cases left where the size can change, but so far I haven't found a way to fix that without making the layout worse in more common scenarios, so I wonder if we should just leave this as-is.

Amy, did you have a specific plan here? Would you like to give this another try or do you agree we can leave this as-is?

That has been my experience as well. Let's leave as-is.