1779633 - Update symbolic to 9.<next>, once released

Status: RESOLVED FIXED

(Eliot :: General, task)

Description

[Markus Stange [:mstange]]

Tecken currently uses symbolic 8.7.3.

The current master branch of symbolic-debuginfo (after 9.0.0) supports INLINE / INLINE_ORIGIN records in breakpad .sym files, as of PR #605.

Once a symbolic release with that fix is cut, Tecken should update to it so that it won't break if Firefox starts including those records in its symbol files (bug 1779631).

Comment 1

[Markus Stange [:mstange]]

The release is going to happen soon: https://github.com/getsentry/publish/issues/1273

Comment 2

[Markus Stange [:mstange]]

https://github.com/mozilla-services/tecken/pull/2579

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 2579: bug 1779633: update symbolic and emit inlines

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #2579: "bug 1779633: update symbolic and emit inlines" in a57952a.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Thank you for doing this!

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Comment on attachment 9292516 [details]
pr 2579: bug 1779633: update symbolic and emit inlines

https://github.com/mozilla-services/tecken/pull/2579#pullrequestreview-1092282824

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

I can't get the attachment working right. It's a GitHub PR link:

https://github.com/mozilla-services/tecken/pull/2579

This went to production just now in bug #1788705.

I tried the curl line from the PR and get this output:

{
  "results": [
    {
      "stacks": [
        [
          {
            "frame": 0,
            "module": "XUL",
            "module_offset": "0x5029c06"
          },
          {
            "frame": 1,
            "module": "XUL",
            "module_offset": "0x334f78"
          },
          {
            "frame": 2,
            "module": "XUL",
            "module_offset": "0x108e77c"
          }
        ]
      ],
      "found_modules": {
        "XUL/EC1363211A96381FA0C96D6301E7574A0": false
      }
    },
    {
      "stacks": [
        [
          {
            "frame": 0,
            "module": "libmozglue.dylib",
            "module_offset": "0x1d17f"
          },
          {
            "frame": 1,
            "module": "libmozglue.dylib",
            "module_offset": "0x33f2a"
          },
          {
            "frame": 2,
            "module": "libmozglue.dylib",
            "module_offset": "0x1bc0"
          }
        ]
      ],
      "found_modules": {
        "libmozglue.dylib/E0BD475866D23370B4B61AE86A5ACFC00": false
      }
    }
  ]
}

I think that's because the symbols expired out of Symbols Server. If there are problems, we can fix them in a new bug. Marking as FIXED.

Comment 8

[Markus Stange [:mstange]]

I've confirmed it works! Example profile from a try build: https://share.firefox.dev/3euDE9M

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

Awesome! Thank you for all the work you did for this!