1779631 - Output inline information in symbol files by passing --inlines to dump_syms

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Markus Stange [:mstange]]

Once dump_syms can output INLINE and INLINE_ORIGIN records (edit: done!), and once we've updated minidump-stackwalk (bug 1779630 + bug 1781930), Tecken (bug 1779633), and fix-stacks (bug 1781819) to not break when they see those records, we should update dump_syms and turn on this feature.

This will allow us to have inline stacks in crash reports (bug 1398533) and in the symbolication API (bug 1636194).

Comment 1

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/jobs?repo=try&revision=307991d43602bfab77353c77079f2134d013f3f0

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1779631 - Pass --inlines to dump_syms. r=gsvelto

Depends on D153656

Comment 3

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/jobs?repo=try&revision=04909e890bf85ffb668fd49b7f3e7972e9f1b745
https://treeherder.mozilla.org/jobs?repo=try&revision=0ff5965fd72019692813fc25883c016861f919ad

Comment 4

[Markus Stange [:mstange]]

I'm pulling the update itself out into bug 1783899.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mstange, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 6

[Gabriele Svelto [:gsvelto]]

We're holding this off for when we're ready

Comment 7

[Markus Stange [:mstange]]

The last remaining blocker for this is a timeout we encountered in this try push, which will hopefully be addressed by the timeout bump in bug 1789414.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff3a983aeae1
Pass --inlines to dump_syms. r=gsvelto

Comment 9

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/ff3a983aeae1