Closed Bug 1780156 Opened 1 year ago Closed 1 year ago

Add context selector to Browser Console

Categories

(DevTools :: Console, task, P2)

Product:
DevTools
Component:
Console
Type:
task

Tracking

(firefox104 fixed)

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1780156 - [devtools] Use private fields in BrowserConsole. r=ochameau.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1780156 - [devtools] Add EvaluationContextSelector to BrowserConsole. r=ochameau.
48 bytes, text/x-phabricator-request
Details | Review

At the moment, we rely on the existence of a toolbox in order to subscribe to its store, and get the different frames in the context switch list.

Once Bug 1619296 lands, we can directly use the target command store instead, and display the context selector in the Browser Console

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2acbfa79b63e
[devtools] Use private fields in BrowserConsole. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/61c455e77edc
[devtools] Add EvaluationContextSelector to BrowserConsole. r=ochameau.

Backed out for causing mochitest on failures browser_console_evaluation_context_selector.js

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_console_evaluation_context_selector.js | context selector is only displayed when Fission or EFT is enabled - Got [object HTMLButtonElement], expected null
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d7b71d8e36f
[devtools] Use private fields in BrowserConsole. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/3155d6ae7c19
[devtools] Add EvaluationContextSelector to BrowserConsole. r=ochameau.
Flags: needinfo?(nchevobbe)

https://hg.mozilla.org/mozilla-central/rev/6d7b71d8e36f
https://hg.mozilla.org/mozilla-central/rev/3155d6ae7c19

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.