1780167 - aboutTelemetry.js references unknown file aboutTelemetry.properties

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Mark Banner (:standard8)]

Bug 1523741 removed aboutTelemetry.properties, but it looks like there is a reference left within aboutTelemetry.js:

https://searchfox.org/mozilla-central/rev/fa71140041c5401b80a11f099cc0cd0653295e2c/toolkit/content/aboutTelemetry.js#38-40

The bundle referenced there is used within StackRenderer.renderHeader, but doesn't seem to break running about:telemetry - maybe StackRenderer is normally (or completely?) unused?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1523741

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:berning5, since you are the author of the regressor, bug 1523741, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[:Gijs (he/him)]

This is only used from the "late writes" section, which is only rendered if there are late writes.

https://searchfox.org/mozilla-central/rev/15b656909e77d3048d4652b894f79a8c719b4b86/toolkit/content/aboutTelemetry.js#2341-2344

The relevant lines have no coverage in automated tests because there are no late writes... This seems unfortunate - from a very quick look, this is currently tricky to do - perhaps the simplest thing would be to have a way to clear the telemetry cache, then write dummy late write stack data into the profile directory, then async fetch the telemetry data and then open about:telemetry.

As it is, AFAICT if there are late writes, about:telemetry will partially break, losing origin telemetry and simple measurements.

Given Avery worked on this as an MSU student 3 years ago, I think we're unlikely to hear back from him - passing needinfo to chutten as this breakage is probably relevant to his interests...

Comment 4

[Chris H-C :chutten]

Attachment: Bug 1780167 - Remove last remaining bundle use from aboutTelemetry r?Gijs!

To test:

1. go to about:telemetry,
   2: inspect the categories,
2. add .has-data to the classes of the Late Writes section,
3. select the now-visible section,
4. in the console run StackRenderer.renderHeader("late-writes", 1)

You should see a header rendered that says "Late Writes #1" in your Firefox's
language.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f5c7a65bcd0
Remove last remaining bundle use from aboutTelemetry r=Gijs

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9f5c7a65bcd0