1780212 - Marionette window restoration is broken on Linux automation

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Which is why I needed to annotate tests in bug 1779559. Pre-existing failures are in: https://searchfox.org/mozilla-central/rev/fa71140041c5401b80a11f099cc0cd0653295e2c/testing/web-platform/meta/page-visibility/minimize.html.ini

This seems to be because gtk_window_deiconify doesn't actually deiconify the window, so the sizemodechange never arrives.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1780212 - Miscellaneous clean-ups to related code. r=Gijs

These don't change behavior but I did them while debugging this.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1780212 - Consistently use sizemodechange events to minimize/restore windows. r=whimboo

Like we do to maximize/fullscreen. This makes the code less confusing
and more reliable over-all.

Depends on D152176

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1780212 - Use gtk_window_present too, to deiconify windows. r=stransky

This does work on Mutter, while gtk_window_deiconify doesn't seem to,
see:

https://stackoverflow.com/questions/24061029/how-to-deiconify-a-window-after-the-click-of-minimize-button-in-gtk

for example.

Depends on D152177

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1780212 - Update test expectations. r=whimboo,stransky

Depends on D152178

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/409297c79d2d
Miscellaneous clean-ups to related code. r=Gijs

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/598d4ad77f18
Consistently use sizemodechange events to minimize/restore windows. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/0fcbd8d0d597
Use gtk_window_present too, to deiconify windows. r=stransky
https://hg.mozilla.org/integration/autoland/rev/692f47ec667f
Update test expectations. r=jdescottes

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/409297c79d2d
https://hg.mozilla.org/mozilla-central/rev/598d4ad77f18
https://hg.mozilla.org/mozilla-central/rev/0fcbd8d0d597
https://hg.mozilla.org/mozilla-central/rev/692f47ec667f

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Emilio, thanks a lot for these changes! They are pretty helpful and make both minimizing and restoring windows way faster. I no longer see the TimedPromise error with a 5s timeout. Now the commands return immediately - which is a drastic improvement!