1779559 - Consider making `document.visibilityState` work in chrome docs (reflect window occlusion)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Emilio Cobos Álvarez (:emilio)]

Seems it'd make the code a bit simpler and more consistent.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1779559 - Make tabbrowser manage chrome BC activeness. r=Gijs

Just like it manages content, so that we stop chrome animations and such
in hidden or fully-occluded windows too. This already happened on macOS
for minimized windows via PauseCompositor, but this should be better and
more consistent.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1779559 - Do this in toolkit instead. r=Gijs

This simplifies a bit the tabbrowser/tab switcher code, and makes it
work in all windows.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d3f5ad32cd2
Make tabbrowser manage chrome BC activeness. r=Gijs

Comment 4

[Cristian Tuns]

Backed out for causing multiple bc failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | Test timed out -
• Failure Log 2
• Failure line 2: TEST-UNEXPECTED-FAIL | browser/base/content/test/gesture/browser_gesture_navigation.js | should be stopping anim -

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1779559 - Disable Windows' window occlusion in some more mochitests. r=Gijs

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea2b3be0fb5c
Disable Windows' window occlusion in some more mochitests. r=sotaro

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a68a015349ed
Make tabbrowser manage chrome BC activeness. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/23fe4f24d483
Do this in toolkit instead. r=Gijs

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/645bdd59bb99
Annotate a test on Linux for now.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eab896a61170
Annotate another Linux test for now.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbb29df4aa9e
Disable occlusion in another mochitest.

Comment 11

[Cristian Tuns]

Backed out for causing wpt failures on unload-bubbles.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-TIMEOUT | /page-visibility/unload-bubbles.html | visibilitychange event bubbles when fired on unload - Test timed out

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/939cb6d24171
Make tabbrowser manage chrome BC activeness. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/02862be5276f
Do this in toolkit instead. r=Gijs

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/939cb6d24171
https://hg.mozilla.org/mozilla-central/rev/02862be5276f

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ea2b3be0fb5c3cac980dd87b491cfe2cd0652b20

Comment 15

[Florian Quèze [:florian]]

Thanks for fixing this!

Here is a profile of the tab throbber animation with the patches applied: https://share.firefox.dev/3RHLaNE

(Steps to reproduce: I loaded http://tests.themasta.com/load-never-finishes.php in a tab (this page keeps the tab loading animation going forever), started the profiler, and then made the window fully occluded (in a way that Mac OS would detect, ie. I resized the window to avoid touching the left/right edges of the screen to avoid bug 1779557).)

What I see in the profile: when the window is fully occluded, the RefreshDriverTick (and CSS animation iteration) markers are throttled in the parent process main thread (the patches work!), but the full activity continues in the Renderer and Compositor threads, ie I can still reproduce bug 1768495.

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Release Note Request (optional, but appreciated)
[Why is this notable]: Reduces battery usage by throttling animations in our UI inside occluded or minimized windows.
[Affects Firefox for Android]: no
[Suggested wording]: The Firefox UI itself will now be throttled for performance and battery usage when minimized or occluded, in the same way background tabs are.
[Links (documentation, blog post, etc)]: n/a