1780242 - Firefox View collapse arrows should have aria roles and state that indicate what they do

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P2)

Description

[Josh Berman]

Actual: Both chevrons and supporting content underneath headers for Tab content and Recently closed are acting as accordions (when using voiceover) but both lack aria roles which effectively describe their functionality as accordions.
Expected: User is informed when focusing on the chevron button or the supporting copy button that this is a button and the information under the button is either collapsed or expanded.

Example of expected implementation of accordions : http://web-accessibility.carnegiemuseums.org/code/accordions/

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Disability Access APIs' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[:Gijs (he/him)]

Bad bot... moving this back.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sfoster, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Sarah Clements [:sclements]]

Attachment: Bug 1780242 - Add aria labels to collapsible container elements r=morgan

• Add aria labels and role to button and div that contains the content

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41bff817f113
Add aria labels to collapsible container elements r=fluent-reviewers,morgan,flod

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/41bff817f113

Comment 7

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello ,

I have uncovered the following results using these builds 106.0b4(20220925185751) and 107.0a1(20220925213821)

For Windows 10 (NVDA screen reader):

• 106.0b4 - NVDA does not read the chevron buttons , does not read the Tab Pickup progress bar percentage (be it 11% , 33% etc.)
• 107.0a1 - same behaviour as above
  (it does say expanded/collapsed when pressing the chevron buttons)

For macOS (VoiceOver):

• 106.0b4 - Voice Over reads the 1st chevron(tab pickup) but not the second one (Recently Closed) , also reads the Tab Pickup progress bar percentage (be it 11%, 33%)
• 107.0a1 - Voice over reads everything properly without any issues(both chevrons and Tab Pickup percentages)
  (it does say expanded/collapsed when pressing the chevron buttons)

For Ubuntu (Orca Reader):

• 106.0b4 - Orca does not read the chevron buttons , does not read the Tab Pickup progress bar percentage (be it 11% , 33% etc.)
• 107.0a1 - same behaviour as above
  (it does say expanded/collapsed when pressing the chevron buttons)

Comment 8

[Sarah Clements [:sclements]]

(In reply to Vlad Lucaci, QA (:vlucaci) from comment #7)

Hello ,

I have uncovered the following results using these builds 106.0b4(20220925185751) and 107.0a1(20220925213821)

For Windows 10 (NVDA screen reader):

• 106.0b4 - NVDA does not read the chevron buttons , does not read the Tab Pickup progress bar percentage (be it 11% , 33% etc.)
• 107.0a1 - same behaviour as above
  (it does say expanded/collapsed when pressing the chevron buttons)

For macOS (VoiceOver):

• 106.0b4 - Voice Over reads the 1st chevron(tab pickup) but not the second one (Recently Closed) , also reads the Tab Pickup progress bar percentage (be it 11%, 33%)
• 107.0a1 - Voice over reads everything properly without any issues(both chevrons and Tab Pickup percentages)
  (it does say expanded/collapsed when pressing the chevron buttons)

For Ubuntu (Orca Reader):

• 106.0b4 - Orca does not read the chevron buttons , does not read the Tab Pickup progress bar percentage (be it 11% , 33% etc.)
• 107.0a1 - same behaviour as above
  (it does say expanded/collapsed when pressing the chevron buttons)

Ok, so it looks like there's still an issue with Windows 10 and Ubuntu not reading everything properly even though we changed to using details and summary in bug 1784902. Thanks for flagging this. I've filed a new bug 1792440 for it. Do you know if the behavior on Windows or Ubuntu is a regression or if this patch didn't fix it either?

Comment 9

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed based on comment 3 of 1792440.