1784902 - Wrap Tab Pickup and Recently Closed Tabs headers in the collapsible button [a11y]

Status: VERIFIED FIXED

(Firefox :: Firefox View, enhancement, P1)

Description

[Sarah Clements [:sclements]]

During review of 1780242, Morgan pointed out that if someone is using a magnifier then the arrow up/down button for both of these sections is off-screen and not obvious to those particular users. She suggested wrapping the header in the button.

Josh, is this alright to do? Gijs recommended we run this change by UX first to ensure we won't catch users by surprise that the header is clickable and will collapse the list. If this change isn't approved we'll need to find an alternative solution.

Comment 1

[Josh Berman]

Yes, aligned. Thanks!

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1784902 - Implement the collapsible fx-view sections as details/summary elements. r?gijs!,ayeddi

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59536058a947
Implement the collapsible fx-view sections as details/summary elements. r=Gijs

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset 59536058a947 (Bug 1784902) for causing failures in browser_setup_state.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=FQhsu8zZQ1-46CPdm9Zz2g.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=windows%2C7%2Cwebrender%2Copt%2Cmochitests%2Ctest-windows7-32-qr%2Fopt-mochitest-browser-chrome%2Cbc5&revision=59536058a947eeefa822ca21b7554eedd02aff98

Log: https://treeherder.mozilla.org/logviewer?job_id=389241136&repo=autoland&lineNumber=4814

Backout: https://hg.mozilla.org/integration/autoland/rev/eb36f12753ddcc804d09b51b85bf6c3b03eb364d

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc1490291109
Implement the collapsible fx-view sections as details/summary elements. r=Gijs

Comment 7

[Sam Foster [:sfoster] (he/him)]

Thanks for the backout. It was a proper forehead-slapper and I'm glad we had a test to catch it to avoid further embarrassment on my part :)

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/bc1490291109

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Confirming that the Tab pickup and Recently closed headers are clickable and will collapse/ expand the sections accordingly on click with Firefox 106.0 (20220815214739) on Windows 10x64, macOS 11 and Ubuntu 21.04.

Also when clicking on the Tab pickup and Recently closed headers while using a Magnifier on Windows 10x64 the magnified focus will move to display the content.