1780429 - Display Pin Private Browsing Promo based off Pref

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

In Fx105, we want to display pin promo on opening about:privatebrowsing when pref 'browser.promo.pin.enabled' is set to true.
Promotion will be showing 3 times a week (total lifetime 12) followed by Focus Promo with frequency 3 times a week(total lifetime 12).

To show/hide Pin promo based off pref 'browser.promo.pin.enabled' , we should move PB_NEWTAB_PIN_PROMO from PanelTestProvider.jsm to OnboardingMessageProvider.jsm and set 'browser.promo.pin.enabled' in firefox.js to false.

This will allow QA to test feature in Fx105 by flipping the pref

https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/PanelTestProvider.jsm#665

Please note in Fx104 , Pin Promo can only be seen via Nimbus experiment such as
https://experimenter.services.mozilla.com/nimbus/pin-private-windows-to-taskbar

Comment 1

[Negin Sauermann]

Attachment: Bug 1780429 - Display Pin Private Browsing Promo based off Pref

Comment 2

[Punam Dahiya [:pdahiya]]

NI @venetia if there is visibility into by when we will have finalized strings which can be submitted for localization thanks!

Comment 3

[Vtay]

All the pin private windows strings are final! Figma is up-to-date!

Comment 4

[Punam Dahiya [:pdahiya]]

Link to figma https://www.figma.com/file/DuYnaE2DxETEbBFUOrNzyM/Privacy-Segmentation

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c64e5592dc67
Display Pin Private Browsing Promo based off Pref  r=pdahiya,flod

Comment 6

[Sandor Molnar[:smolnar]]

Backed out changeset c64e5592dc67 (bug 1780429) for causing xpc failures in toolkit/modules/tests/xpcshell/test_BrowserUtils.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/3c1c16d99f7571fef4e487fbb95079d853a73bc0

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f8e174553dc
Display Pin Private Browsing Promo based off Pref r=emcminn,flod

Comment 8

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/9f8e174553dc

Comment 9

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 105.0a1 (Build ID: 20220809213127) on Windows 10 x64, macOS 12.3.1, and Linux Mint 20.2 x64.

• The “Pin Private Browsing” promo is displayed on “about:privatebrowsing” after flipping the “browser.promo.pin.enabled” pref to true.
• The promo is displayed on three consecutive tabs followed by “Firefox Focus” promo. (if the “Pin Private Browsing” promo is not dismissed/pinned)
• The “Pin Private Browsing” promo is shown 3 times a week (total lifetime 12) followed by the “Firefox Focus” promo which is also displayed 3 times a week (total lifetime 12).
• Also, the “Pin Private Browsing” promo is not shown on macOS and Linux distros, and the “Firefox Focus” promo is displayed even if the “browser.promo.pin.enabled” pref is set to true.