1780834 - WebP image on istockphoto is not displayed

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Nomis101]

The image on this page is displayed in Safari and Google Chrome on Mac, but not in Firefox.
https://www.istockphoto.com/de/foto/cocktail-am-pool-genie%C3%9Fen-gm950688808-259497731

The Image is in webp format. image.webp.enabled is set to true. Firefox gives an error in the console "Image corrupt or truncated." After investigating the picture it seems the image contains XML metadata.

Tested with Firefox 102 and 104.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1780834. If a webp file header specifies ICCP but no ICCP chunk is found just ignore it and continue. r?aosmond

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79318e646218
If a webp file header specifies ICCP but no ICCP chunk is found just ignore it and continue. r=aosmond

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/79318e646218

Comment 4

[Nomis101]

Thanks for the fix. I can verify that this is fixed now. I was wondering if it would be possible to have this fixed in 102ESR as well? Or is there something against it?

Comment 5

[Timothy Nikkel (:tnikkel)]

I'll ask Ryan about 102ESR.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Seems reasonable. Go ahead and nominate for Beta and ESR102.

Comment 7

[Timothy Nikkel (:tnikkel)]

Comment on attachment 9286754 [details]
Bug 1780834. If a webp file header specifies ICCP but no ICCP chunk is found just ignore it and continue. r?aosmond

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: some webp images not displayed
• User impact if declined: some webp images not displayed
• Fix Landed on Version: 105
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): we process the webp file the same as every other webp that doesn't have a single bit set in the header

Beta/Release Uplift Approval Request

• User impact if declined: some webp images not displayed
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): we process the webp file the same as every other webp that doesn't have a single bit set in the header
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9286754 [details]
Bug 1780834. If a webp file header specifies ICCP but no ICCP chunk is found just ignore it and continue. r?aosmond

Approved for 104.b3

Comment 9

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4ce194cc254a

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9286754 [details]
Bug 1780834. If a webp file header specifies ICCP but no ICCP chunk is found just ignore it and continue. r?aosmond

Approved for 102.2esr

Comment 11

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/40922c97ff03