1794754 - return NEED_MORE_DATA from nsWebPDecoder::ReadHeader if ICC was specified but chunk not found

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1794754. Return NEED_MORE_DATA from nsWebPDecoder::ReadHeader if ICC was specified but chunk not found r?aosmond

Bug 1780834 caused this bug. If we are not complete then we might need to
wait for more data to come in that has the ICCP chunk.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1780834

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1780834

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63ddef7c4373
Return NEED_MORE_DATA from nsWebPDecoder::ReadHeader if ICC was specified but chunk not found r=aosmond

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/63ddef7c4373

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tnikkel, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Timothy Nikkel (:tnikkel)]

Comment on attachment 9298147 [details]
Bug 1794754. Return NEED_MORE_DATA from nsWebPDecoder::ReadHeader if ICC was specified but chunk not found r?aosmond

Beta/Release Uplift Approval Request

• User impact if declined: icc color profile of webp files could be ignored in some circumstances
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): very small change to move us closer to what we used to do
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9298147 [details]
Bug 1794754. Return NEED_MORE_DATA from nsWebPDecoder::ReadHeader if ICC was specified but chunk not found r?aosmond

Approved for 107.0b4.

Comment 9

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3f4985864757