Closed Bug 1781008 Opened 21 days ago Closed 10 days ago

Add JSContext-free variant of AutoCheckRecursionLimit

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

js::AutoCheckRecursionLimit is used for checking stack limit inside frontend, and it uses JSContext to access JS::RootingContext::nativeStackLimit

https://searchfox.org/mozilla-central/search?q=AutoCheckRecursionLimit&path=js%2Fsrc%2Ffrontend&case=false&regexp=false

That part needs to be refactored in order to remove the JSContext dependency

The error reporting part needs bug 1773324 patches.

Depends on: 1773324
Priority: -- → P1
Depends on: 1781183

bug 1781183 will handle the stack limit part.
error reporting part will be handled here.

Blocks: 1781255
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED

Depends on D152779

WASI uses extra JSContext fields to track the recursion depth.
Given WASI doesn't support thread, move it to JSContext and
MainThreadErrorContext.

Depends on D152781

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/9c5f59e32d19
Part 1: Move ReportOverRecursed implementation to JSContext and ErrorContext. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/dd0966996f42
Part 2: Add BytecodeEmitter::ec. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/241f5f4edede
Part 3: Use ErrorContext instead of JSContext for error reporting in AutoCheckRecursionLimit in frontend. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/65f1ba1ea8b0
Part 4: Wrap WASI recursion check with JSContext and ErrorContext functions. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/a39537ee543a
Part 5: Use JSContext-free variant of AutoCheckRecursionLimit in frontend. r=bthrall
Keywords: leave-open
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/b8d281829ff6
Part 6: Move comment about WASI recursion limit. r=bthrall
Status: ASSIGNED → RESOLVED
Closed: 10 days ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.