1781008 - Add JSContext-free variant of AutoCheckRecursionLimit

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

js::AutoCheckRecursionLimit is used for checking stack limit inside frontend, and it uses JSContext to access JS::RootingContext::nativeStackLimit

https://searchfox.org/mozilla-central/search?q=AutoCheckRecursionLimit&path=js%2Fsrc%2Ffrontend&case=false&regexp=false

That part needs to be refactored in order to remove the JSContext dependency

Comment 1

[Tooru Fujisawa [:arai]]

The error reporting part needs bug 1773324 patches.

Comment 2

[Tooru Fujisawa [:arai]]

bug 1781183 will handle the stack limit part.
error reporting part will be handled here.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781008 - Part 1: Move ReportOverRecursed implementation to JSContext and ErrorContext. r?bthrall!

Depends on D152778

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781008 - Part 2: Add BytecodeEmitter::ec. r?bthrall!

Depends on D152779

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781008 - Part 3: Use ErrorContext instead of JSContext for error reporting in AutoCheckRecursionLimit in frontend. r?bthrall!

Depends on D152780

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781008 - Part 4: Wrap WASI recursion check with JSContext and ErrorContext functions. r?bthrall!

WASI uses extra JSContext fields to track the recursion depth.
Given WASI doesn't support thread, move it to JSContext and
MainThreadErrorContext.

Depends on D152781

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781008 - Part 5: Use JSContext-free variant of AutoCheckRecursionLimit in frontend. r?bthrall!

Depends on D152782

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c5f59e32d19
Part 1: Move ReportOverRecursed implementation to JSContext and ErrorContext. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/dd0966996f42
Part 2: Add BytecodeEmitter::ec. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/241f5f4edede
Part 3: Use ErrorContext instead of JSContext for error reporting in AutoCheckRecursionLimit in frontend. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/65f1ba1ea8b0
Part 4: Wrap WASI recursion check with JSContext and ErrorContext functions. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/a39537ee543a
Part 5: Use JSContext-free variant of AutoCheckRecursionLimit in frontend. r=bthrall

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1781008 - Part 6: Move comment about WASI recursion limit. r?bthrall!

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9c5f59e32d19
https://hg.mozilla.org/mozilla-central/rev/dd0966996f42
https://hg.mozilla.org/mozilla-central/rev/241f5f4edede
https://hg.mozilla.org/mozilla-central/rev/65f1ba1ea8b0
https://hg.mozilla.org/mozilla-central/rev/a39537ee543a

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8d281829ff6
Part 6: Move comment about WASI recursion limit. r=bthrall

Comment 12

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/b8d281829ff6