Closed Bug 1781066 Opened 1 year ago Closed 1 year ago

Fix handling of undefined in pointerMove and wheel actions


(Remote Protocol :: Marionette, defect, P1)



(firefox107 fixed)

107 Branch
Tracking Status
firefox107 --- fixed


(Reporter: jgraham, Assigned: jgraham)


(Blocks 1 open bug)


(Whiteboard: [webdriver:m4][webdriver:external], [wptsync upstream])


(1 file)

The spec currently says it's OK to pass in undefined as x, y in pointer move and wheel scroll actions, and also deltaX and deltaY in wheel scroll actions. But it then goes on to assume that those values are integers.

The spec should change to require that those fields are not undefined, and the implementation in geckodriver/marionette updated to match.

The spec claims that undefined is allowed for these values, but later
treats them as if they're always integers. I suspect the original
intent was to default to 0, but since there seems to be interop around
rasing an exception, make geckodriver and marionette explicitly check
for valid integers and disallow missing/undefined values.

Assignee: nobody → james
Priority: -- → P1
Whiteboard: [webdriver:m4][webdriver:external]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(hskupin)
Severity: -- → S3
Flags: needinfo?(hskupin)

As it looks like this patch waits for bug 1746601 to be fixed? I'm going to add the dependency.

Depends on: 1746601

FYI the referenced pull request has been merged last week. So we are good to go with landing a patch.

James, I assume we should get this landed as well for the 0.32.0 release of geckodriver. Do you agree? If yes we should be able to get the patch reviewed?

Flags: needinfo?(james)

Yes, I think we should review and land this if possible.

Flags: needinfo?(james)
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.
Whiteboard: [webdriver:m4][webdriver:external] → [webdriver:m4][webdriver:external], [wptsync upstream error]
Whiteboard: [webdriver:m4][webdriver:external], [wptsync upstream error] → [webdriver:m4][webdriver:external], [wptsync upstream]
Pushed by
Disallow missing pointerMove / wheel scroll coordinates, r=webdriver-reviewers,whimboo
Whiteboard: [webdriver:m4][webdriver:external], [wptsync upstream] → [webdriver:m4][webdriver:external], [wptsync upstream error]
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Flags: needinfo?(james)

James, the upstream wptsync failed here before and I assume this happened again? I cannot find a listed PR here. Maybe you can have a look?

Flags: needinfo?(james)
Created web-platform-tests PR for changes under testing/web-platform/tests
Whiteboard: [webdriver:m4][webdriver:external], [wptsync upstream error] → [webdriver:m4][webdriver:external], [wptsync upstream]
Flags: needinfo?(james)

(In reply to Web Platform Test Sync Bot (Matrix: from comment #13)

Created web-platform-tests PR for changes under

Note that this PR got already merged three days ago even there was no update from the bot.

Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.