Closed Bug 1781434 Opened 4 months ago Closed 3 months ago

Frequent toolkit/components/prompts/test/test_modal_prompts.html | single tracking bug

Categories

(Toolkit :: General, defect, P3)

defect

Tracking

()

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: jmaher, Assigned: emilio)

References

(Depends on 1 open bug)

Details

(Keywords: intermittent-failure, intermittent-testcase, Whiteboard: [stockwell disabled])

Attachments

(2 files)

No description provided.

Additional information about this bug failures and frequency patterns can be found by running: ./mach test-info failure-report --bug 1781434

Flags: needinfo?(dtownsend)
Summary: Intermittent toolkit/components/prompts/test/test_modal_prompts.html | single tracking bug → Ferquent toolkit/components/prompts/test/test_modal_prompts.html | single tracking bug
Summary: Ferquent toolkit/components/prompts/test/test_modal_prompts.html | single tracking bug → Frequent toolkit/components/prompts/test/test_modal_prompts.html | single tracking bug

Hi Emilio, can you please take a look? I believe failure rate increased when bug 1740989 landed.

Flags: needinfo?(emilio)
Flags: needinfo?(dtownsend)
Assignee: nobody → emilio
Flags: needinfo?(emilio)

Make it a bit easier to read and less prone to race conditions. Remove a
setTimeout referencing bug 103197 which I'm pretty sure it's not an
issue.

Whiteboard: [stockwell disable-recommended] → [stockwell needswork:owner]
Whiteboard: [stockwell disable-recommended] → [stockwell needswork:owner]
Whiteboard: [stockwell disable-recommended] → \
Whiteboard: \
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8de3f54dc3ca
Clean-up dialog initial focus code. r=pbz,Gijs

Backed out for causing mochitest failures on test_dialogfocus.xhtml . CLOSED TREE
Backout link
Push with failures
Link to failure log
Failure line :
TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_dialogfocus.xhtml | Test timed out. -

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ddeff2468d8
Clean-up dialog initial focus code. r=pbz,Gijs
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6a154ada951
Tentative fix tor test_bug398289.html CLOSED TREE

Hi Emilio. Please re-enable the test in your fix.
Thank you!

Keywords: leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0eddbfaa7a62
temporarily disable test_modal_prompts.html on win10_2004 r=intermittent-reviewers,jmaher DONTBUILD
Attachment #9293274 - Attachment description: Bug 1781434 - Clean-up dialog initial focus code. r=pbz,mossop → Bug 1781434 - Clean-up dialog initial focus code. r=pbz,Gijs
Flags: needinfo?(emilio)
Keywords: leave-open
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/149d45b6a85b
Clean-up dialog initial focus code. r=pbz,Gijs
Regressions: 1791473

Backed out for causing mochitest failures on test_bug398289.html

Backout link

Push with failures

Failure log

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ec569867b48
Clean-up dialog initial focus code. r=pbz,Gijs
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

Hi Emilio, this is still happening on mozilla-beta, can you request an uplift?
Failure log: https://treeherder.mozilla.org/logviewer?job_id=391157046&repo=mozilla-beta&lineNumber=7387

Flags: needinfo?(emilio)

I'd rather let it run the trains. Probably uplift the disable patch instead if needed? I'm not sure if that needs approval.

Flags: needinfo?(emilio)
See Also: → 1793324
Regressions: 1796408
No longer regressions: 1796408
Regressions: 1796408
You need to log in before you can comment on or make changes to this bug.