1781806 - Address bar keeps inheriting autofill in new tabs for windows that were created by moving/dragging a tab

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Kestrel]

Attachment: Video showing address bar autofilling by itself when creating new tabs

STR:

1. Drag a tab into a new window or right-click > Move Tab > Move To New Window.
2. Type the letter "m" in the address bar, autofill suggests mozilla.org.
3. Create multiple new tabs (eg Ctrl+T).

Expected:
Address bar is empty in new tabs.

Actual:
Address bar autofills with mozilla.org and dropdown appears automatically, obscuring the new tab page. This behavior persists for the lifetime of the window.

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=db2e1d780268ab0a7dca1ea1ca81febcb33e926e&tochange=6ba63b50d93083c798f4eccdbeded15441bd1979

Address bar related changes in regression window: Bug 1632744 and Bug 1412985.

Comment 1

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Async triage with Dianna on Slack - mark firefox104-status as wontfix

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:adw, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Drew Willcoxon :adw]

Confirming on Nightly, thanks for the regression range. Bug 1632744 is almost certainly not related, and bug 1412985 doesn't seem related either but I can't rule it out like the other one. This almost looks more like a session store bug where state is being improperly retained on tab move and/or tab creation in the new window.

The regression range doesn't include any obvious other bugs. The only one that stands out to me is bug 1580565, which made some changes to browsing context stuff, but I don't think that would cause this.

Comment 4

[Mark Banner (:standard8)]

NI to Marco to try and do a manually regression range.

Comment 5

[Marco Bonardo [:mak] (Away 10-21 August)]

Unfortunately most of the changesets don't build and would require build hacks to work.
I could just confirm the regression is in the autoland to central merge, but couldn't go much further. We'll have to debug it as usual.
It's likely something with userTypedValue not being set properly.

Comment 6

[James Teow [:jteow]]

Attachment: Bug 1781806 - Trigger afterTabSwitchFocusChange in the Urlbar even if the tab is already selected and is going to receive a TabSelect event - r?mak

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f6a2cef5be9
Trigger afterTabSwitchFocusChange in the Urlbar even if the tab is already selected and is going to receive a TabSelect event - r=tabbrowser-reviewers,dao

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4f6a2cef5be9

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-06-21 Nightly build on Windows 10.
Verified as fixed on Nightly 116.0a1(build ID: 20230626215144) on Windows 10, macOS 12, Ubuntu 22.
Address bar is now empty in new tabs.

Comment 10

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:jteow, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.