1839724 - Consider removing afterTabSwitchFocusChange

Status: NEW

(Firefox :: Address Bar, task, P2)

Description

[James Teow [:jteow]]

Currently, the Urlbar keeps two internal properties (this._gotFocusChange and this._gotTabSelect) that guard against calling autoOpen until the two properties are true. This requires keeping them in sync with one another.

If one is left true while the other is not, the boolean value will persist until both are true, which can cause unintended behaviour as found with Bug 1781806.

:mak has started a WIP sketch of how this could work whereby the logic is completely contained within _on_TabSelect, removing the need for afterTabSwitchFocusChange.

Comment 1

[Marco Bonardo [:mak] (Away 10-21 August)]

Attachment: tabselectpatch.diff

let me attach the snippet so it doesn't get lost.