Closed Bug 1781888 Opened 3 years ago Closed 2 years ago

Intermittent browser/components/search/test/browser/browser_search_telemetry_sources_navigation.js | single tracking bug

Categories

(Firefox :: Search, defect, P3)

Product:
Firefox
Component:
Search
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: jmaher, Assigned: jteow)

References

Details

(Keywords: intermittent-failure, intermittent-testcase, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Bug 1781888 - Prevent persist search tip from showing in telemetry test - r?standard8
48 bytes, text/x-phabricator-request
Details | Review
No description provided.

Additional information about this bug failures and frequency patterns can be found by running: ./mach test-info failure-report --bug 1781888

Update:

There have been 33 failures within the last 7 days:

  • 24 failures on Linux 18.04 x64 WebRender debug
  • 1 failure on Linux 18.04 x64 WebRender tsan opt
  • 8 failures on OS X 10.15 WebRender debug

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=398573908&repo=autoland&lineNumber=10309

[task 2022-12-04T02:14:47.611Z] 02:14:47     INFO - TEST-PASS | browser/components/search/test/browser/browser_search_telemetry_sources_navigation.js | there should be a first suggestion - 1 >= 0 - 
[task 2022-12-04T02:14:47.612Z] 02:14:47     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "https://example.com/browser/browser/components/search/test/browser/SearchTelemetry.html" line: 0}]
[task 2022-12-04T02:14:47.612Z] 02:14:47     INFO - Buffered messages finished
[task 2022-12-04T02:14:47.613Z] 02:14:47     INFO - TEST-UNEXPECTED-FAIL | browser/components/search/test/browser/browser_search_telemetry_sources_navigation.js | Uncaught exception in test - should have the expected keyed scalars - timed out after 50 tries.
[task 2022-12-04T02:14:47.614Z] 02:14:47     INFO - Leaving test bound test_fresh_search

Mark, can you help us assign this to someone?
Thank you.

Flags: needinfo?(standard8)
Whiteboard: [stockwell needswork:owner]

There's a line in the log that says console.debug: SearchTelemetry: "Counting ad click in page for" "example" "urlbar_persisted"...

We should be logging urlbar here, so I think this may have been caused by the persisted search terms that James has been working on. James can you take a look please?

Flags: needinfo?(standard8) → needinfo?(jteow)

After some investigation, I think I know what's happening. This is related to Bug 1803056.

First, test_search does a search which goes to a SERP.

Then, test_reload reloads the page before clicking on an ad.

In between the click and loading the ad, a SERP search tip might appear.

When the search tip shows up, it's going to set userTypedValue to the search term.

Using that setter sets this._startedLoadSinceLastUserTyping = false; which will cause onLocationChange in tabbrowser.js to not nullify the userTypedValue once the ad page is loaded because it respects user input after a load has initiated. Thus, we won't reset the showingSearchTerms boolean on the browser-custom-element done in UrlbarInput.setURI.

As a consequence, when test_fresh_search makes a search from the existing browser object, it'll trigger a search that telemetry think is urlbar_persisted.

Best thing for me to do is fix Bug 1803056 and then see if it fixes this intermittent.

Depends on: 1803056

Just as an update, I'm still in the midst of working on the bug that I believe is causing this.

James, can we go ahead and disable this and the test in Bug 1792718 until there's a fix in place? Do you think you can tackle this before the holidays?

Flags: needinfo?(jteow)
Flags: needinfo?(jteow)

Hi Cosmin, I am going to try landing a patch today that should result in less failures from browser_search_telemetry_sources_navigation.js. It won't fix Bug 1792718, so I'll discuss with :standard8 and get back to you on an ETA.

Flags: needinfo?(jteow)

Patch landed in https://bugzilla.mozilla.org/show_bug.cgi?id=1803056#c7. Let's see how failure rate goes from here. Thank you James.

It looks like there's still an intermittent happening, albeit it's a different error message from the previous weeks. I'll try writing a patch before the end of week. If it's happening at the same frequency as previous days and I don't think I can get the patch done, I'll see if we can skip the test on affected platforms until I can tackle it again after the holidays.

Assignee: nobody → jteow
Status: NEW → ASSIGNED
Attachment #9309461 - Attachment description: Bug 1781888 - Prevent persist search tip from showing on urlbar-persist telemetry test - r?adw → Bug 1781888 - Prevent persist search tip from showing on urlbar-persist telemetry test - r?standard8
Depends on: 1807032

I think addressing Bug 1803056 fixed a good percentage of the failures. I added Bug 1807032 which I believe is causing an issue with Linux Debug builds, but I'm going to hold off from trying to land that until after the holidays.

Whiteboard: [stockwell disable-recommended] → [stockwell needswork:owner]
Whiteboard: [stockwell disable-recommended] → [stockwell needswork:owner]
Attachment #9309461 - Attachment description: Bug 1781888 - Prevent persist search tip from showing on urlbar-persist telemetry test - r?standard8 → WIP: - Bug 1781888 - Dismiss persist search tip when visible - r?standard8
Attachment #9309461 - Attachment description: WIP: - Bug 1781888 - Dismiss persist search tip when visible - r?standard8 → Bug 1781888 - Prevent persist search tip from showing in telemetry test - r?standard8
Pushed by jteow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fee0975f1dbf Prevent persist search tip from showing in telemetry test - r=Standard8

https://hg.mozilla.org/mozilla-central/rev/fee0975f1dbf

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: