1803056 - Sub-pages display the search term if they're clicked as the persist search tip is displayed

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: persisted search term in subpages

Found in

• Fx 109.0a1

Affected versions

• Fx 109.0a1
• Fx 108.0b7

Affected platforms

• Windows 10

Preconditions
browser.urlbar.showSearchTerms.featureGate set to true.
browser.urlbar.searchTips.test.ignoreShowLimits set to true. This makes the issue easier to catch.

Steps to reproduce

1. Launch Firefox.
2. Input a search term and press enter.
3. In the SERP click on Images/Videos/News subpages displayed beneath the websearch bar right as the search tip is displayed. (this is a bit more dificult to time, but it can happen).

Expected result

• FULL url is displayed.

Actual result

• Search term is persisted in the subpages.

Regression range

• This is not a regression.

Additional notes

• The issue occurs with Google and Bing, as for DDG the search term is persisted without timing the click with the search tip.
• The issue occurs ONLY if the timing is correct as displayed in the attached video.
• This is a very particular edge case, but it could happen, as the search tip is not displayed right away on a SERP with a persisted term.

Comment 1

[James Teow [:jteow]]

After some investigation, I think this is the cause of a new intermittent failure in browser/components/search/test/browser/browser_search_telemetry_sources_navigation.js.

Before the persist search tip is triggered, we'll have to keep track of whether the browser is loading another page.

Comment 2

[James Teow [:jteow]]

Attachment: Bug 1803056 - Prevent search tips from appearing when a new request is initiated - r?adw

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0677d0ad42a
Prevent search tips from appearing when a new request is initiated - r=adw

Comment 5

[Cristian Tuns]

Backed out for causing mochitest failures on browser-tips/browser_searchTips.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser-tips/browser_searchTips.js | Test timed out -

Comment 6

[James Teow [:jteow]]

I think I've identified the reasons for the failure, going to request another code review before landing again.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eab51c8b1e27
Prevent search tips from appearing when a new request is initiated - r=adw

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/eab51c8b1e27

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jteow, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[James Teow [:jteow]]

For now, I don't think I'll request an uplift since the underlying feature is not enabled in Firefox 109 outside of Nightly builds.

Comment 11

[Cristian Baica [:cbaica], Release Desktop QA]

Marking the issues as verified fixed as I cannot catch the case anymore.