1782091 - Create IdentityCredential state map

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, enhancement, P1)

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: WIP: Bug 1782091, part 1 - Create IdentityCredential state map, WIP

First creation of the FedCM account state map.

This is a disk key-value store that holds the map as described by https://fedidcg.github.io/FedCM/#browser-api-state-machine.
In particular, the values are stored as JSON defined in the WebIDL here and the keys are rpOrigin|idpOrigin|base64(credentialID).

TODO: Don't persist from within Private Browsing
TODO: support the ClearDataService as an extension of the permissions or passwords

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1782091 - Create IdentityCredential state map, r=timhuang!,pbz!

This creates a new service that stores precisely two bits per RP, IDP, and account ID tuple:
has it been used before and is it able to be logged out.

It does so with the additional constraints of respecting private browsing's clear on last session and in-memory storage constraints and being a participant in the Clear Storage Service.

Tests are here. Coverage isn't perfect, but they cover most of the service.

Comment 3

[Iulian Moraru]

Backed out for causing multiple failures.

Push with failures

Failure log for xpcshell failures on test_forget_about_site_security_headers.js
Failure log for mochitest plain chrashes
Failure log for bc failures on browser_394759_purge.js related to ForgetAboutSite.jsm
also there are multiple TV failures on test_identity_credential_storage_service.js

Backout link

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f38f252060f
Create IdentityCredential state map, r=timhuang,pbz

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2030d35f960
Create IdentityCredential state map, r=timhuang,pbz

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing multiple mozStorageService related failures

Backout link

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1475247d538f
Create IdentityCredential state map, r=timhuang,pbz

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures in toolkit/components/cleardata/tests/browser/browser_quota.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a6577d5920c698d8aac2e77d3cc6fc249d4d4702

Push with failures

Failure log

INFO - Buffered messages finished
[task 2022-12-02T22:26:25.361Z] 22:26:25     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/cleardata/tests/browser/browser_quota.js | 16777216 == 0 - JS frame :: chrome://mochitests/content/browser/toolkit/components/cleardata/tests/browser/browser_quota.js :: runTest/</< :: line 98
[task 2022-12-02T22:26:25.361Z] 22:26:25     INFO - Stack trace:

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8927ee6631c
Create IdentityCredential state map, r=timhuang,pbz

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d8927ee6631c