1899319 - Two bit flags have same value in nsIClearDataService

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, defect, P1)

Description

[William Wen (:wwen)]

Two flags used to clear data in the nsIClearDataService have the same value.

https://searchfox.org/mozilla-central/source/toolkit/components/cleardata/nsIClearDataService.idl#280-288

I can submit a quick patch for it although I'm still not sure how possible an automated test is.

Comment 1

[William Wen (:wwen)]

Attachment: Bug 1899319 - Change bit flags to not have duplicate values. r=bvandersloot

Comment 2

[Emma Zühlcke [:emz]]

Well spotted! Thanks for submitting a patch too.

(In reply to William Wen (:wwen) from comment #0)

I can submit a quick patch for it although I'm still not sure how possible an automated test is.

I think adding something based on what we discussed would be good:

Object.keys(Ci.nsIClearDataService).filter(k => k.startsWith("CLEAR_"))

Unfortunately my browser console currently doesn't work so I can't test this myself. You might have to manually exclude certain group flags along with the CLEAR_ALL one. but it's better than nothing :-)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1782091

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86c93771026b
Change bit flags to not have duplicate values. r=bvandersloot,pbz

Comment 5

[Emma Zühlcke [:emz]]

Please don't close bugs before they have landed. The sheriffs will close the bugs once the patch has landed.

Comment 6

[William Wen (:wwen)]

My bad, thought status published == bug closed

Comment 7

[Daniel Holbert [:dholbert]]

Expanding on comment 5: the bug's not considered fixed until the patch merges to mozilla-central, since that's what Nightly is built from (and what ultimately merges to beta, etc).

The phabricator "published" status just means that it landed on autoland (e.g. comment 4); but often a half-day or so can go by between merges from autoland to mozilla-central (or more, in rare cases where there's substantial bustange on autoland that needs cleaning up, or other infrastructure issues).

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/86c93771026b

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:wwen, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.