1782130 - Add Pin Private Window to Taskbar modal in Existing Users Onboarding

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to add standalone Pin Private Window to Taskbar screen in existing users onboarding. Screen is shown after Mobile Cross promo for users on Windows only that have pinned Firefox to Taskbar, but have not pinned the private Window .

We should make sure this screen is not displayed to. users who have pinned Firefox to taskbar during MR onboarding as that has a checkbox option asking user to private pin.

https://docs.google.com/document/d/1Zlo9PNfjIbJb2hHlRwSaHqL17y_Z_qZZGxrwA6z94g8/edit#heading=h.mfbz477ulklv

https://docs.google.com/document/d/15e5Pa6WBur8vAzC9pcfL7wQ_mZimvIsZMETZpnPutXE/edit

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1782130 - Add Pin Private Window to Taskbar modal in Existing Users Onboarding

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c31112612884
Add Pin Private Window to Taskbar modal in Existing Users Onboarding r=jprickett,flod

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c31112612884

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm the following:

• The "Pin Private Window" modal is displayed after the "Mobile Cross-Promo" one if Firefox is pinned to the taskbar/dock.
• The "Private Window" shortcut is pinned to the taskbar after the modal's primary button is clicked.
• The "Pin Private Window" modal is NOT displayed if Firefox is NOT pinned to the taskbar/dock.
  Verified using the latest Firefox Nightly (105.0a1 Build ID - 20220817190533) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64.

However, during testing, I have observed that the "Pin Private Window" modal is displayed even if the "Private Browsing" shortcut is already pinned to the taskbar, and after further investigation, I have logged a separate issue for this behavior. You can find it here: Bug 1785814.