1782273 - Enable prettier for self-hosted code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[André Bargull [:anba]]

We currently have a mix of old 4-space tabs and new 2-space tabs in self-hosted JS code. Let's enable prettier to make this more consistent.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 1: Apply two space indent for js/src/builtin/Array.js. r=tcampbell!

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 2: Fix whitespace in js/src/builtin/Array.js. r=tcampbell!

Depends on D153235

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 3: Rewrap lines in js/src/builtin/Array.js. r=tcampbell!

Depends on D153236

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 4: Remaining prettier errors in js/src/builtin/Array.js. r=tcampbell!

Depends on D153237

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 5: Apply two space indent for js/src/builtin/{AsyncFunction,AsyncIteration,BigInt,Date}.js. r=tcampbell!

Depends on D153238

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 6: Rewrap lines in js/src/builtin/{AsyncFunction,AsyncIteration,Date,Error}.js. r=tcampbell!

Depends on D153239

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 7: Remaining prettier errors in js/src/builtin/{AsyncIteration,Date,Error}.js. r=tcampbell!

Depends on D153240

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 8: Apply two space indent for js/src/builtin/{Function,Generator,Iterator,Map,Number,Object,Promise,Reflect}.js. r=tcampbell!

Depends on D153241

Comment 9

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 9: Rewrap lines in js/src/builtin/{Function,Iterator,Map,Object,Promise,Reflect}.js. r=tcampbell!

Depends on D153242

Comment 10

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 10: Remaining prettier errors in js/src/builtin/{Map,Object,Promise,Reflect}.js. r=tcampbell!

Depends on D153243

Comment 11

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 11: Apply two space indent for js/src/builtin/RegExp*.js. r=tcampbell!

Depends on D153244

Comment 12

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 12: Rewrap lines in js/src/builtin/RegExp*.js. r=tcampbell!

Depends on D153245

Comment 13

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 13: Remaining prettier errors in js/src/builtin/RegExp*.js. r=tcampbell!

Depends on D153246

Comment 14

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 14: Apply two space indent for js/src/builtin/{Set,Sorting,Tuple,Utilities,WeakMap,WeakSet}.js. r=tcampbell!

Depends on D153247

Comment 15

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 15: Rewrap lines in js/src/builtin/{Set,Sorting,Tuple,Utilities}.js. r=tcampbell!

Depends on D153248

Comment 16

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 16: Remaining prettier errors in js/src/builtin/{Set,Tuple}.js. r=tcampbell!

Depends on D153249

Comment 17

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 15: Apply two space indent for js/src/builtin/String.js. r=tcampbell!

Depends on D153250

Comment 18

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 18: Rewrap lines in js/src/builtin/String.js. r=tcampbell!

Depends on D153251

Comment 19

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 19: Remaining prettier errors in js/src/builtin/String.js. r=tcampbell!

Depends on D153252

Comment 20

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 20: Apply two space indent for js/src/builtin/TypedArray.js. r=tcampbell!

Depends on D153253

Comment 21

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 21: Rewrap lines in js/src/builtin/TypedArray.js. r=tcampbell!

Depends on D153254

Comment 22

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 22: Fix whitespace in js/src/builtin/TypedArray.js. r=tcampbell!

Depends on D153255

Comment 23

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 23: Remaining prettier errors in js/src/builtin/TypedArray.js. r=tcampbell!

Depends on D153256

Comment 24

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 24: Fix prettier errors in eslintrc. r=tcampbell!

Depends on D153257

Comment 25

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 25: Apply two space indent for js/src/builtin/intl/*.js. r=tcampbell!

Depends on D153258

Comment 26

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 26: Rewrap lines in js/src/builtin/intl/*.js. r=tcampbell!

Depends on D153259

Comment 27

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 27: Remaining prettier errors in js/src/builtin/intl/*.js. r=tcampbell!

Depends on D153260

Comment 28

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 28: Reformat generated Intl to match prettier. r=tcampbell!

Depends on D153261

Comment 29

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 30: Enable prettier for selfhosted code. r=tcampbell!

The "prettierrc" matches almost the top-level "prettierrc", except for two changes:

• "printWidth" is changed to 100, because we have many long lines.
• "quoteProps" is changed to "consistent" to handle the
  sanctionedSimpleUnitIdentifiers array.

Depends on D153262

Comment 30

[Ted Campbell [:tcampbell]]

We've embraced clang-format for all the C++ and been happier for it. Adding some consistency to self-hosting makes for one less thing to think about when writing it, so this sounds good.

Comment 31

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 29: Rewrap self-hosted code at 80 columns. r=tcampbell!

Comment 32

[André Bargull [:anba]]

Attachment: Bug 1782273 - Part 31: Remove prettier overrides.

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29ba93e15767
Part 1: Apply two space indent for js/src/builtin/Array.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/48911a329fcc
Part 2: Fix whitespace in js/src/builtin/Array.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/d28d5b505b12
Part 3: Rewrap lines in js/src/builtin/Array.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/480f3be49bf1
Part 4: Remaining prettier errors in js/src/builtin/Array.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/dd16540f2123
Part 5: Apply two space indent for js/src/builtin/{AsyncFunction,AsyncIteration,BigInt,Date}.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/71fdd9221205
Part 6: Rewrap lines in js/src/builtin/{AsyncFunction,AsyncIteration,Date,Error}.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/1e5c20b1a804
Part 7: Remaining prettier errors in js/src/builtin/{AsyncIteration,Date,Error}.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/ff084083223d
Part 8: Apply two space indent for js/src/builtin/{Function,Generator,Iterator,Map,Number,Object,Promise,Reflect}.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/64885a01f4c2
Part 9: Rewrap lines in js/src/builtin/{Function,Iterator,Map,Object,Promise,Reflect}.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/38a2a58b4811
Part 10: Remaining prettier errors in js/src/builtin/{Map,Object,Promise,Reflect}.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/953af7b6e4ec
Part 11: Apply two space indent for js/src/builtin/RegExp*.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/601f77dbe7c9
Part 12: Rewrap lines in js/src/builtin/RegExp*.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/b2c80460a4ff
Part 13: Remaining prettier errors in js/src/builtin/RegExp*.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/5ab0db00d8cf
Part 14: Apply two space indent for js/src/builtin/{Set,Sorting,Tuple,Utilities,WeakMap,WeakSet}.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/9904a8855f7b
Part 15: Rewrap lines in js/src/builtin/{Set,Sorting,Tuple,Utilities}.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/f07b36c9f54d
Part 16: Remaining prettier errors in js/src/builtin/{Set,Tuple}.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/cabdf7282126
Part 15: Apply two space indent for js/src/builtin/String.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/4f6cdc668207
Part 18: Rewrap lines in js/src/builtin/String.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/19b76ea0f786
Part 19: Remaining prettier errors in js/src/builtin/String.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/b387d0933e42
Part 20: Apply two space indent for js/src/builtin/TypedArray.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/30f04fe93a0b
Part 21: Rewrap lines in js/src/builtin/TypedArray.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/51bb9288e5f0
Part 22: Fix whitespace in js/src/builtin/TypedArray.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/d9b43f4633f8
Part 23: Remaining prettier errors in js/src/builtin/TypedArray.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/c317e8916990
Part 24: Fix prettier errors in eslintrc. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/7d28e64fe6b9
Part 25: Apply two space indent for js/src/builtin/intl/*.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/1c3ad91ce8ec
Part 26: Rewrap lines in js/src/builtin/intl/*.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/f94c2d3cf7ae
Part 27: Remaining prettier errors in js/src/builtin/intl/*.js. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/94e6e04ec617
Part 28: Reformat generated Intl to match prettier. r=tcampbell

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de70aed071a2
Part 29: Rewrap self-hosted code at 80 columns. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/f8fc3c47d6ed
Part 30: Enable prettier for selfhosted code. r=tcampbell,Standard8

Comment 35

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/29ba93e15767
https://hg.mozilla.org/mozilla-central/rev/48911a329fcc
https://hg.mozilla.org/mozilla-central/rev/d28d5b505b12
https://hg.mozilla.org/mozilla-central/rev/480f3be49bf1
https://hg.mozilla.org/mozilla-central/rev/dd16540f2123
https://hg.mozilla.org/mozilla-central/rev/71fdd9221205
https://hg.mozilla.org/mozilla-central/rev/1e5c20b1a804
https://hg.mozilla.org/mozilla-central/rev/ff084083223d
https://hg.mozilla.org/mozilla-central/rev/64885a01f4c2
https://hg.mozilla.org/mozilla-central/rev/38a2a58b4811
https://hg.mozilla.org/mozilla-central/rev/953af7b6e4ec
https://hg.mozilla.org/mozilla-central/rev/601f77dbe7c9
https://hg.mozilla.org/mozilla-central/rev/b2c80460a4ff
https://hg.mozilla.org/mozilla-central/rev/5ab0db00d8cf
https://hg.mozilla.org/mozilla-central/rev/9904a8855f7b
https://hg.mozilla.org/mozilla-central/rev/f07b36c9f54d
https://hg.mozilla.org/mozilla-central/rev/cabdf7282126
https://hg.mozilla.org/mozilla-central/rev/4f6cdc668207
https://hg.mozilla.org/mozilla-central/rev/19b76ea0f786
https://hg.mozilla.org/mozilla-central/rev/b387d0933e42
https://hg.mozilla.org/mozilla-central/rev/30f04fe93a0b
https://hg.mozilla.org/mozilla-central/rev/51bb9288e5f0
https://hg.mozilla.org/mozilla-central/rev/d9b43f4633f8
https://hg.mozilla.org/mozilla-central/rev/c317e8916990
https://hg.mozilla.org/mozilla-central/rev/7d28e64fe6b9
https://hg.mozilla.org/mozilla-central/rev/1c3ad91ce8ec
https://hg.mozilla.org/mozilla-central/rev/f94c2d3cf7ae
https://hg.mozilla.org/mozilla-central/rev/94e6e04ec617
https://hg.mozilla.org/mozilla-central/rev/de70aed071a2
https://hg.mozilla.org/mozilla-central/rev/f8fc3c47d6ed