1782355 - Replace remaining services.settings.server usage with correct alternatives

Status: NEW

(Firefox :: Remote Settings Client, task)

Description

[Rob Wu [:robwu]]

In bug 1780554, an issue occurred due to the removal of the services.settings.server pref in https://hg.mozilla.org/mozilla-central/rev/54cf464f80b5. The pref wasn't actually used in practice on release due to the changes in bug 1598562.

I audited the codebase and looked for other places where services.settings.server is referenced.

This should have checked Utils.SERVER_URL + AppConstants.REMOTE_SETTINGS_SERVER_URL instead:

• https://searchfox.org/mozilla-central/rev/39fbb3f218776be3392d056f86cfbf54614767d6/services/settings/Utils.jsm#405

These lines should also be cleaned up:

• https://searchfox.org/mozilla-central/rev/39fbb3f218776be3392d056f86cfbf54614767d6/toolkit/components/backgroundtasks/BackgroundTask_message.jsm#178-185

The usage of the pref should probably be re-evaluated, possibly by replacing it with the REMOTE_SETTINGS_SERVER_URL compile-time flag:

• https://searchfox.org/mozilla-central/rev/39fbb3f218776be3392d056f86cfbf54614767d6/toolkit/xre/nsAppRunner.cpp#269
• https://searchfox.org/mozilla-central/rev/39fbb3f218776be3392d056f86cfbf54614767d6/toolkit/mozapps/defaultagent/docs/index.rst#43