1782380 - input type="Color" color-picker does not appear, when you activate the button using 'accesskey' (with "<input> picker was blocked due to lack of user activation")

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

STR:

1. Have devtools open (before you load the testcase)
2. Load the testcase.
3. Alt-Shift+C to activate the input-color-widget via keyboard accesskey (it has accesskey='c')

ACTUAL RESULTS:

• console shows that we fired the onclick handler
• However, the input color-picker dialog does not appear, and instead we show this warning in the devtools console:

<input> picker was blocked due to lack of user activation.

EXPECTED RESULTS:
The color picker dialog should show up (rather than the warning about lack of user activation). The accesskey here is a method of user activation.

Note: if you click an arbitrary spot on the page before entering the accesskey-key-command, then you get EXPECTED RESULTS. (We interpret that click as a user activation, and that classification seems to extend long enough to envelope the accesskey action as well.)

Comment 1

[Daniel Holbert [:dholbert]]

I get ACTUAL RESULTS in Nightly on Linux.
I get EXPECTED RESULTS in Nightly on macOS.
Haven't tested Windows yet.

Comment 2

[Daniel Holbert [:dholbert]]

If I set about:config pref to dom.disable_open_during_load, then I get EXPECTED RESULTS on Linux.

Testing with Nightly 105.0a1 (2022-07-30) (64-bit).

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1782380 - Consider trusted accesskey event user activation. r=edgar

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1782380 - Fix accesskey on file input. r=edgar,smaug

By not propagating to the inner button. This probably broke with
bug 505355 since it made the button not focusable.

Depends on D153309

Comment 5

[Phabricator Automation]

Comment on attachment 9287869 [details]
Bug 1782380 - Fix accesskey on file input. r=edgar,smaug

Revision D153321 was moved to bug 1780199. Setting attachment 9287869 [details] to obsolete.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebaf499e2d87
Consider trusted accesskey event user activation. r=edgar

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ebaf499e2d87