1678389 - File / Color input popup silently doesn't show up if called after an async call due to the popup blocker.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

These checks can cause issues in cases like this:

https://stackoverflow.com/questions/64916575/file-browser-is-not-opening-after-ajax-call-in-firefox

It seems like we should be able to figure out a way to properly propagate the user activation in this case.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1678389 - Use transient user activation for <input> file/color picker. r=edgar,smaug

This matches other browsers, see 1, and should fix this and other
similar bugs like bug 1610726.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b21f364898eb
Use transient user activation for <input> file/color picker. r=edgar

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset b21f364898eb (Bug 1678389) for causing Android gv-unit failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=JHY4MIrtSG-lnME84O6W6Q.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=b21f364898eb8fe7414cda89d3a45ebc48771353

Failure log: https://treeherder.mozilla.org/logviewer?job_id=322560605&repo=autoland&lineNumber=9136

Backout: https://hg.mozilla.org/integration/autoland/rev/1c991028c6dce5f6892cc1a077b5b2cd9cf27322

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec16588c8163
Use transient user activation for <input> file/color picker. r=edgar,smaug

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ec16588c8163

Comment 8

[Oliver Medhurst [:canadahonk]]

Sorry to necro, afaict this doesn't match Chromium as here we consume, whereas linked Chromium code only checks if active without consuming?