1782405 - Backdrop-filter distorts while animating after bug 1768678

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Gregory Pappas [:gregp]]

Attachment: distortion.mp4

Steps to reproduce:

1. Navigate to https://codepen.io/konstantindenerz/full/oNNaEVp

Actual results:
Distortion

Expected results:
Smooth animation

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1768678

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:gw, since you are the author of the regressor, bug 1768678, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Glenn Watson [:gw]]

Attachment: Bug 1782405 - Fix UV sampling rect for blurs with downscale-adjusted sizes

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/674181b6e86a
Fix UV sampling rect for blurs with downscale-adjusted sizes r=gfx-reviewers,lsalzman

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/674181b6e86a

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gw, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox104 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Glenn Watson [:gw]]

Comment on attachment 9287859 [details]
Bug 1782405 - Fix UV sampling rect for blurs with downscale-adjusted sizes

Beta/Release Uplift Approval Request

• User impact if declined: Visual artifacts on some backdrop-filter effects, as well as animated blurs.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Per repro steps in bug.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Clear bug fix, small patch.
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 105.0a1 (20220731212434) on Windows 10x64. There is a distortion when loading the animation from comment 0.
The issue is verified fixed with Firefox 105.0a1 (20220802214455) on Windows 10x64, macOS 11 and Ubuntu 21. The distortion can no longer be seen when playing the animation from comment 0.

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9287859 [details]
Bug 1782405 - Fix UV sampling rect for blurs with downscale-adjusted sizes

Approved for 104.0b6

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2773312b5cbf

Comment 11

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 104.0b6 (20220803114555) from comment 9 on Windows 10x64, macOS 11 and Ubuntu 20/21. The distortion can no longer be seen on the attached test case.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9287859 [details]
Bug 1782405 - Fix UV sampling rect for blurs with downscale-adjusted sizes

Approved for 102.2esr.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/ea5afc64f4f2

Comment 14

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: 1782405_1.gif

Hello! I tried to verify the issue with Firefox 102.2.0esr (20220815170108) on Windows 10x64, macOS 11 and Ubuntu 21 but it seems that the blur animation is not present on this version of Firefox esr. I attached a video with Firefox Nightly on the right side and Firefox 102esr on the left side. Is this something that is disabled on Firefox esr or should we file a new issue for this? Thank you in advance!

Comment 15

[Gregory Pappas [:gregp]]

Alexandru, backdrop-filter is disabled in Firefox 102 by default. It can be enabled by setting layout.css.backdrop-filter.enabled to true in about:config

Comment 16

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Gregory Pappas from comment #15)

Alexandru, backdrop-filter is disabled in Firefox 102 by default. It can be enabled by setting layout.css.backdrop-filter.enabled to true in about:config

Thank you, Gregory. I verified this again by setting layout.css.backdrop-filter.enabled to true in Firefox Firefox 102.2.0esr (20220815170108) and I can no longer see the initial issue from comment 0.
However, I can see an animation skip if the browser is maximized or the page is scrolled at a certain point while the browser is not maximized. I logged another issue for this (bug 1785207) and I will close this one as verified because the issue is not so visible and I don't know if this is a Firefox bug or the test case.