1782646 - Prevent default identity's settings being overwritten by Account Settings page

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Geoff Lankow (:darktrojan)]

If the Account Settings tab is open, and the default identity changes (e.g. by a sync operation) the new default identity's settings will be overwritten by the old default's when Manage Identities is clicked. This is because the values from am-main.xhtml are saved before am-identities-list.xhtml is displayed.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1782646 - Prevent default identity's settings being overwritten by Account Settings page. r=mkmelin

Make account settings refresh if the default identity is changed. The default identity should always be displayed, then saving its values won't overwrite the wrong identity.

Depends on D153825

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bada07cc3228
Prevent default identity's settings being overwritten by Account Settings page. r=mkmelin

Comment 3

[Magnus Melin [:mkmelin]]

Geoff, should we uplift this? I'm seeing an error fixed by this in bug 1798197.

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9288587 [details]
Bug 1782646 - Prevent default identity's settings being overwritten by Account Settings page. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: account manager UI doesn't reflect reality if the default identity changes
Testing completed (on c-c, etc.): landed in 105
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9288587 [details]
Bug 1782646 - Prevent default identity's settings being overwritten by Account Settings page. r=mkmelin

[Triage Comment]
Approved for esr102

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 102.5.0:
https://hg.mozilla.org/releases/comm-esr102/rev/030d21b0be3e