1782918 - The calculation for folder compacting does not match size displayed in the user interface

Status: RESOLVED DUPLICATE of bug 1260698

(Thunderbird :: Folder and Message Lists, defect)

Description

[adrien.rybarczyk]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.5005.63 Safari/537.36

Steps to reproduce:

In the preferences tab,
"Compact all folders when it will save over MB in total"
does not seem to be correct with regard to the calculations in nsMsgDBFolder.cpp

Actual results:

if (totalExpungedBytes > ((int64_t)purgeThreshold * 1024)) {

totalExpungedBytes seems to be defined in bytes.
In the interface the field offlineCompactFolderMin seems to be expressed in kb, not mb.

Expected results:

Change the translation to "when it saves at least XXXX KB in total" or change the calculation.

PS: if the user has "Ask every time before compacting" unchecked, if ever the compacting is not done, a popup will be displayed to the user that the compacting could not be done.
While he had originally asked not to be notified.

Comment 1

[Magnus Melin [:mkmelin]]

There was a migration to using MB some versions ago. I think the code is right
https://searchfox.org/comm-central/rev/7ff2e028e5582fdbc9485b1188e33f83aa64d797/mailnews/base/src/nsMsgDBFolder.cpp#1900

Comment 2

[adrien.rybarczyk]

I just saw, yes it looks good.
However, for a 1024 MB setting, I have already had cases where the compacting is triggered and in the end saves 100 MB.

Comment 3

[Wayne Mery (:wsmwk)]

(In reply to adrien.rybarczyk from comment #2)

I just saw, yes it looks good.
However, for a 1024 MB setting, I have already had cases where the compacting is triggered and in the end saves 100 MB.

We've had issues reported where compacting is prematurely triggered.

Comment 4

[Wayne Mery (:wsmwk)]

Adrien,
Are you still seeing this with version 128 or newer?

Comment 5

[adrien.rybarczyk]

Yes, there are always cases where it displays an impossible amount of space to save
An example from today:

Comment 6

[adrien.rybarczyk]

Attachment: beforeCompacting.PNG

Comment 7

[adrien.rybarczyk]

Attachment: afterCompacting.PNG

Comment 8

[Wayne Mery (:wsmwk)]

adrien, are you still seeing this issue?

Possible duplicate to Bug 1260698 - Compact folders - shows wrong estimated and compacted size. Compacts too often. totalExpungedBytes number is wrong.

Comment 9

[adrien.rybarczyk]

I haven't had any recent cases with impossible values.

However, I still have noticed differences between what's displayed in the popup and what's displayed in the gain once the compression is done.