Closed Bug 178305 Opened 21 years ago Closed 21 years ago

typeahead find auto-wrap broken

Categories

(SeaMonkey :: Find In Page, defect, P1)

Product:
SeaMonkey
Component:
Find In Page
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.2final

People

(Reporter: timeless, Assigned: aaronlev)

References

(
URL
)

Details

Attachments

(1 file)

Get next search variables at point in loop after we know value of aFirstVisiblePreferred
3.04 KB, patch
asa
: review+
asa
: superreview+
asa
: approval+
Details | Diff | Splinter Review 
build: 10/31-04 w32
steps:
1. load the page
2. press ctrl-end
3. type /cygnus
3' expect to find cygnus (there are seven instances: the google url, google's
header, is free, registry, inquiry email, url, and info email)
3` actual result: search for cygn, cygu, and then cygs failed (this is before
the typeahead correction code was removed)
argh, you're right -- I see it now.
Blocks: isearch
Severity: minor → major
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P1
Target Milestone: --- → mozilla1.2final
http://www.mozilla.org/quality/browser/front-end/testcases/keyboard-nav/taf_functional.html

Check out testcase I. It fails for me on 2002102608. 

You can try a text search for any of the text strings, and it just dosen't work
-- it won't wrap around at all.
Blocks: 1.2
Summary: typeahead find for /cygnus fails when started from the end of this page → typeahead find auto-wrap broken
Comment on attachment 105168 [details] [diff] [review]
Get next search variables at point in loop after we know value of aFirstVisiblePreferred

r=kyle
Attachment #105168 - Flags: review+
This stinks, I really think we should try to get this into 1.2.
Bz gave verbal sr= on IRC, but couldn't get Bugzilla working so he went to bed.
Comment on attachment 105168 [details] [diff] [review]
Get next search variables at point in loop after we know value of aFirstVisiblePreferred

sr=bzbarsky
Attachment #105168 - Flags: superreview+
checked in
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Reopening for the 1.2 branch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
removing dependency to drivers' tracking bug. those dependencies are only set by
drivers and correspond to bugs drivers are soliciting, not necessarily requests
for approval.
No longer blocks: 1.2
Comment on attachment 105168 [details] [diff] [review]
Get next search variables at point in loop after we know value of aFirstVisiblePreferred

a=asa for checkin to the 1.2 branch (on behalf of drivers)
Attachment #105168 - Flags: approval+
Comment on attachment 105168 [details] [diff] [review]
Get next search variables at point in loop after we know value of aFirstVisiblePreferred

Testing...
Checked into 1.2 branch.
Status: REOPENED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
looks good --vrfy'd fixed with 2002.11.19 comm trunk builds.
Status: RESOLVED → VERIFIED
OS: Windows 2000 → All
Hardware: PC → All
Component: Keyboard: Navigation → Keyboard: Find as you Type
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.