178305 - typeahead find auto-wrap broken

Status: VERIFIED FIXED

(SeaMonkey :: Find In Page, defect, P1)

Description

[timeless]

build: 10/31-04 w32
steps:
1. load the page
2. press ctrl-end
3. type /cygnus
3' expect to find cygnus (there are seven instances: the google url, google's
header, is free, registry, inquiry email, url, and info email)
3` actual result: search for cygn, cygu, and then cygs failed (this is before
the typeahead correction code was removed)

Comment 1

[Aaron Leventhal]

argh, you're right -- I see it now.

Comment 2

[Owen Marshall (Not reading bugmail)]

http://www.mozilla.org/quality/browser/front-end/testcases/keyboard-nav/taf_functional.html

Check out testcase I. It fails for me on 2002102608. 

You can try a text search for any of the text strings, and it just dosen't work
-- it won't wrap around at all.

Comment 3

[Aaron Leventhal]

Attachment: Get next search variables at point in loop after we know value of aFirstVisiblePreferred

Seeking r=/sr=

Comment 4

[Kyle Yuan]

Comment on attachment 105168 [details] [diff] [review]
Get next search variables at point in loop after we know value of aFirstVisiblePreferred

r=kyle

Comment 5

[Aaron Leventhal]

This stinks, I really think we should try to get this into 1.2.

Comment 6

[Aaron Leventhal]

Bz gave verbal sr= on IRC, but couldn't get Bugzilla working so he went to bed.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 105168 [details] [diff] [review]
Get next search variables at point in loop after we know value of aFirstVisiblePreferred

sr=bzbarsky

Comment 8

[Aaron Leventhal]

checked in

Comment 9

[Aaron Leventhal]

Reopening for the 1.2 branch.

Comment 10

[Asa Dotzler [:asa]]

removing dependency to drivers' tracking bug. those dependencies are only set by
drivers and correspond to bugs drivers are soliciting, not necessarily requests
for approval.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 105168 [details] [diff] [review]
Get next search variables at point in loop after we know value of aFirstVisiblePreferred

a=asa for checkin to the 1.2 branch (on behalf of drivers)

Comment 12

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 105168 [details] [diff] [review]
Get next search variables at point in loop after we know value of aFirstVisiblePreferred

Testing...

Comment 13

[Aaron Leventhal]

Checked into 1.2 branch.

Comment 14

[sairuh (rarely reading bugmail)]

looks good --vrfy'd fixed with 2002.11.19 comm trunk builds.