1783096 - [CTW] <label for> not exposed in cached relations for initial cache push

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

Test case:
data:text/html,<label for="input">label</label><input id="input">
The LABELLED_BY and LABEL_FOR relations aren't exposed as they should be. However, if you add the for attribute later (as the test currently does), it works as expected.

From Matrix:

eeejay:
in  RemoteAccessibleBase<Derived>::PreProcessRelations ,  if (data.mValidTag && TagName() != data.mValidTag)... 
if it is an initial push TagName will return null
so you can't compare tag names yet
this impacts the  for  relation that only works with labels
morgan:
so if that happens, we still need to make sure  updateTracker  has a  true  value for that rel, because there might be a rel in  aFields  that needs to go into mCachedFields once it's initialized
Jamie:
Another approach would be to try aFields->GetAttribute<RefPtr<nsAtom>>(nsGkAtoms::tag) if TagName() returns null.

Comment 1

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1783096: Attempt to fetch tag from aFields if TagName() is null r?Jamie

Depends on D153797

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/272ea1f35d78
Attempt to fetch tag from aFields if TagName() is null r=Jamie

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/272ea1f35d78