1783293 - Network and certificate error pages have a bunch of unused telemetry code hanging around

Status: RESOLVED FIXED

(Firefox :: Security, task)

Description

[:Gijs (out for now; he/him)]

bug 1681839, bug 1563355 and bug 1241455 moved and removed various bits here, and bug 1533951 tried to carefully preserve some of it - but it was already broken.

AFAICT:

• TLS_ERROR_REPORT_UI as a histogram is unused and can be removed.
• Nothing sends Browser:SSLErrorReportTelemetry anymore so the listener can be removed
• Nothing listens for AboutNetErrorUIExpanded anymore so we can stop creating the event.

There might be more loose ends to tie up here, I stopped looking at some point.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:serg, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Manuel Bucher [:manuel]]

Mentioned things got taken care of in the meantime.

• TLS_ERROR_REPORT_UI and AboutNetErrorUIExpanded got removed in Bug 1862062, D192398
• noone listents to Browser:SSLErrorReportTelemetry anymore https://searchfox.org/mozilla-central/search?path=&q=Browser%3ASSLErrorReportTelemetry

Let's close this bug.

Comment 3

[:Gijs (out for now; he/him)]

(In reply to :Gijs (he/him) from comment #0)

• Nothing listens for AboutNetErrorUIExpanded anymore so we can stop creating the event.

This is still there.

Comment 4

[:Gijs (out for now; he/him)]

Attachment: Bug 1783293 - remove unused event dispatching from network/cert error pages, r?manuel

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8fff9ccd78a
remove unused event dispatching from network/cert error pages, r=manuel

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e8fff9ccd78a