1783437 - [Wayland] Tooltips may not show if there's another popup window opened

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Tooltips may not show if there's another popup window opened due to wrong popup coordinates or wrong anchor.

Comment 1

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1783437 [Wayland] Use GtkWindow to check and place tooltips r?emilio

• In order to get tooltip position we need to use gtk_window_get_position() as it cover case when GdkWindow is not placed yet.
• Use both gdk_window_move()/gdk_window_move() to reset widget position as a workaround for https://gitlab.gnome.org/GNOME/gtk/-/issues/4071.
• Apply the workaround to tooltips only as it affects only temporary windows.

Comment 2

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1783437 [Wayland] Don't use move-to-rect when popup and its parent are not adjacent r?emilio

Move-to-rect fails to position and show a popup when popup anchor is outside of its parent window.
In such case we need to use plain move.

Depends on D153859

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1783437 [Wayland] Move move-to-rect config to nsWindow::WaylandPopupCheckAndGetAnchor() r?emilio

Move popup window move-to-rect config (anchor canculation, check if we need it and can use it) to a new method WaylandPopupCheckAndGetAnchor().

Depends on D153860

Comment 4

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1783437 [Wayland] Make sure we don't use rectangle anchor with zero width/height r?emilio

Depends on D154012

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47ebd9b76062
[Wayland] Use GtkWindow to check and place tooltips r=emilio
https://hg.mozilla.org/integration/autoland/rev/c9411a52753e
[Wayland] Don't use move-to-rect when popup and its parent are not adjacent r=emilio
https://hg.mozilla.org/integration/autoland/rev/b172d1e6cffa
[Wayland] Move move-to-rect config to nsWindow::WaylandPopupCheckAndGetAnchor() r=emilio
https://hg.mozilla.org/integration/autoland/rev/cafd5d446af8
[Wayland] Make sure we don't use rectangle anchor with zero width/height r=emilio

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/47ebd9b76062
https://hg.mozilla.org/mozilla-central/rev/c9411a52753e
https://hg.mozilla.org/mozilla-central/rev/b172d1e6cffa
https://hg.mozilla.org/mozilla-central/rev/cafd5d446af8