1802399 - The tooltips of toolbar buttons were cut off by the right of the screen when another popup menu was shown

Status: UNCONFIRMED

(Core :: Widget: Gtk, defect, P5)

Description

[Matt Fagnani]

Attachment: firefox-109.0a1-2022-11-24-toolbar-tooltips-cut-off-on-right.mp4

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0

Steps to reproduce:

I started Firefox 109.0a1 20221124212638 on Wayland in Plasma 5.26.3 in a Fedora 37 KDE Plasma installation. I had previously enabled the menu bar. I clicked on Help, Bookmarks, and other menus in the menu bar. At other times, I selected the Extended tracking protection, Site information buttons in the address bar, or the Pocket button in the toolbar. I moved the cursor over the toolbar buttons View history..., Show sidebars, Extensions, and the hamburger button after one of those popups was shown, and I hovered over them for at least a second so that their tooltips were shown.

Actual results:

The tooltips of toolbar buttons View history..., Show sidebars, Extensions, and the hamburger button were cut off by the right of the screen when another popup menu was shown. Part of the text of the tooltips couldn't be seen as a result. These tooltips weren't cut off when another popup menu wasn't shown. I'm attaching a recording of this problem happening with 109.0a1 20221124212638 on Wayland in Plasma 5.26.3 in which I clicked on Help in the menu bar and then hovered the cursor over the four right toolbar buttons I mentioned.

This problem didn't happen with 109.0a1 20221124212638 on XWayland, so it might be Wayland-specific. The problem happened with 109.0a1 20221124093251 on Wayland in GNOME 43.1 while I was looking into Bug 1802363. The problem happened with 107.0 on Wayland in Plasma, so it might've been introduced in the 107 branch or earlier. I'll try to bisect. This problem might be related to the context menus of bookmarks folders in the bottom third of the screen being cut off by the bottom of the screen which I reported at Bug 1792620.

Expected results:

The tooltips of toolbar buttons shouldn't have been cut off by the right of the screen.

Comment 1

[Matt Fagnani]

105.0a1 2022-08-01 20220801215129 on Wayland didn't have this problem, while 106.0a1 2022-09-01 20220901215206 on Wayland did have the problem. I ran MOZ_ENABLE_WAYLAND=1 mozregression --good 2022-8-1 --bad 2022-9-1 --persist /tmp/mozregression
The final pushlog had four patches for Bug 1783437 involving tooltips and popups on Wayland.

cafd5d446af8e3ebdd218096f7f8e65c9093caa8 stransky — Bug 1783437 [Wayland] Make sure we don't use rectangle anchor with zero width/height r=emilio
b172d1e6cffac58bab39aac9fd3858c2d754e66b stransky — Bug 1783437 [Wayland] Move move-to-rect config to nsWindow::WaylandPopupCheckAndGetAnchor() r=emilio
c9411a52753e2504e2eaa339b1de7041b6b11247 stransky — Bug 1783437 [Wayland] Don't use move-to-rect when popup and its parent are not adjacent r=emilio
47ebd9b7606270a2555eba29d7b6a3a7d1f5118f stransky — Bug 1783437 [Wayland] Use GtkWindow to check and place tooltips r=emilio

10:03.15 INFO: Narrowed integration regression window from [f29f4ba8, 279d1c18] (3 builds) to [f29f4ba8, cafd5d44] (2 builds) (~1 steps left)
10:03.15 INFO: No more integration revisions, bisection finished.
10:03.15 INFO: Last good revision: f29f4ba8462120b365d383032a470a73144af242
10:03.15 INFO: First bad revision: cafd5d446af8e3ebdd218096f7f8e65c9093caa8
10:03.15 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f29f4ba8462120b365d383032a470a73144af242&tochange=cafd5d446af8e3ebdd218096f7f8e65c9093caa8

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:stransky, since you are the author of the regressor, bug 1783437, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

It's https://hg.mozilla.org/integration/autoland/rev/c9411a52753e2504e2eaa339b1de7041b6b11247
We may relax it for tooltips.

Comment 4

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

We may move tooltips away from popup hierarchy.