1783820 - Add resultOwnership support for "script.evaluate" and "script.callFunction"

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

The evaluate and callFunction commands do not handle resultOwnership yet. The default value is "none", but we should also support the "root" value, which means we should return the handle for the root of the return value.

For the record, at the moment resultOwnership is marked as unsupported in the JSDoc. However we are not rejecting commands if a value is provided, we simply ignore it (as opposed to what we do for sandbox and realm parameters).

Blocking on Bug 1770736 because we need the object reference store in order to create our handle ids.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

wdspec tests for callFunction landed via bug 1779066 and for evaluate via bug 1779211.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1783820 - [bidi] Add resultOwnership support for script.evaluate and script.callFunction

Depends on D155445

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1783820 - [bidi] Fix errors lazy imports in RemoteValue

Depends on D155445

The test was only passing because the error thrown was "InvalidArgumentError is not a constructor"

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1783820 - [bidi] Create handle in RemoteValue.serialize if ownershipType is root

Depends on D155632

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1783820 - [bidi] Add a RemoteValue class to hold data for serialized values

Depends on D155862

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a3540c94fdb
[bidi] Fix errors lazy imports in RemoteValue r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/86d453430ba7
[bidi] Create handle in RemoteValue.serialize if ownershipType is root r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/87529a5f58ad
[bidi] Add a RemoteValue class to hold data for serialized values r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/dc1e9c10054b
[bidi] Add resultOwnership support for script.evaluate and script.callFunction r=webdriver-reviewers,Sasha,whimboo

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4a3540c94fdb
https://hg.mozilla.org/mozilla-central/rev/86d453430ba7
https://hg.mozilla.org/mozilla-central/rev/87529a5f58ad
https://hg.mozilla.org/mozilla-central/rev/dc1e9c10054b