[Colorway Closet] Changes made on the second Colorway closet are not applied after closing the first colorway closet
Categories
(Firefox :: Theme, defect)
Tracking
()
People
(Reporter: hyacoub, Unassigned)
References
Details
Found in
- Firefox 105.0a1
Affected versions
- Firefox 105.0a1
Affected platforms
- macOS 11.6
- Windows 10 x64
- Windows 11 x64
- Ubuntu 20.04 x64
Preconditions
In about:config set:
"browser.theme.colorway-closet" to true
"browser.tabs.firefox-view" to true
Steps to reproduce
- Open "Colorways" from Fxview
- Open "Colorways" from about:addons
- From about:addons Colorway select any colorway/intensity and click on "Set Colorway" button
- From FxView close colorway modal
Expected result
The selected colorway/intensity should be applied.
Actual result
Changes made on the second Colorway closet are not applied after closing the first colorway closet.
Regression range
- Not a regression.
|
||
Comment 1•2 years ago
|
||
So when the modal opens, it remembers the previously selected theme in order to being able to revert to that theme when canceling the modal. When the modal opens a second time, previewing a colorway is indistinguishable from setting it from the perspective of the first modal, because it's really an instant apply UI. So while I can see how the user might get confused, I believe we should or rather need to keep the current behavior.
Description
•