1783959 - mach run --enable-fission option doesn't work for GeckoViewExample

Status: RESOLVED FIXED

(Developer Infrastructure :: Developer Environment Integration, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

UnboundLocalError: local variable 'target_profile' referenced before assignment

File "/home/hiro/android/python/mozbuild/mozbuild/mach_commands.py", line 1326, in run
return _run_android(command_context, **kwargs)
File "/home/hiro/android/python/mozbuild/mozbuild/mach_commands.py", line 1437, in _run_android
args = ["--profile", shlex_quote(target_profile)]

Comment 1

[Makoto Kato [:m_kato]]

I don't know why args = ["--profile", shlex_quote(target_profile)] is moved to other block.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1783959 - Add --profile argument when using custom profile. r=#firefox-build-system-reviewers

This is regression by bug 1581971.

When using custom profile to run GVE via ./mach run --profile <directory>,
we add "--profile" argument on adb. But, after landing bug 1581971, we
don't pass any profile arguments unfortunately.

So we should add it to use custom profile.

Also, This fixes that ./mach run --enable-fission is broken. We don't need
--profile argument to run GVE with fission.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1581971

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4830bfab9b2
Add --profile argument when using custom profile. r=firefox-build-system-reviewers,glandium

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d4830bfab9b2